Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove react-sticky dependency #84521

Closed
tylersmalley opened this issue Nov 30, 2020 · 1 comment · Fixed by #84589
Closed

Remove react-sticky dependency #84521

tylersmalley opened this issue Nov 30, 2020 · 1 comment · Fixed by #84589
Labels
Team:APM All issues that need APM UI Team support

Comments

@tylersmalley
Copy link
Contributor

This package is no longer maintained, and since we have dropped IE11 it is no longer necessary as we can use position: sticky
@tylersmalley tylersmalley added the Team:APM All issues that need APM UI Team support label Nov 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

tylersmalley pushed a commit to tylersmalley/kibana that referenced this issue Nov 30, 2020
[APM] Removes react-sticky dependency in favor of using CSS
2ddf7db 
Closes elastic#84521

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit to tylersmalley/kibana that referenced this issue Nov 30, 2020
[APM] Removes react-sticky dependency in favor of using CSS
d345a6d 
Closes elastic#84521

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley mentioned this issue Nov 30, 2020
Merged
tylersmalley pushed a commit to tylersmalley/kibana that referenced this issue Nov 30, 2020
[APM] Removes react-sticky dependency in favor of using CSS
a76347c 
Closes elastic#84521

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit that referenced this issue Dec 3, 2020
[APM] Removes react-sticky dependency in favor of using CSS (#84589)
401047e 
Closes #84521

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit to tylersmalley/kibana that referenced this issue Dec 3, 2020
[APM] Removes react-sticky dependency in favor of using CSS (elastic#…
b281e38 
…84589)

Closes elastic#84521

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit that referenced this issue Dec 3, 2020
[APM] Removes react-sticky dependency in favor of using CSS (#84589) (#…
874df03 
…84853)

Closes #84521

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@sorenlouv sorenlouv mentioned this issue Dec 3, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team:APM All issues that need APM UI Team support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Removes react-sticky dependency in favor of using CSS tylersmalley/kibana
3 participants
@tylersmalley @sorenlouv @elasticmachine