Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] "View job" link from latency charts leads to a malfunctioning page #86774

Closed
dgieselaar opened this issue Dec 22, 2020 · 7 comments · Fixed by #86788
Closed

[APM] "View job" link from latency charts leads to a malfunctioning page #86774

dgieselaar opened this issue Dec 22, 2020 · 7 comments · Fixed by #86788
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.11.0

Comments

@dgieselaar
Copy link
Member

dgieselaar commented Dec 22, 2020

When clicking on the "View job" link from the overview latency chart, the user sees this screen:

image

This is not very helpful, and it also triggers an infinite loop of requests. At first, the errors return 200s, but eventually they error out as ERR_INSUFFICIENT_RESOURCES.

I'm not sure if our link is wrong.

@dgieselaar dgieselaar added bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.11.0 labels Dec 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@dgieselaar
Copy link
Member Author

Spoke to the ML folks and the link is broken:

  • pause should be either 'true' or 'false'
  • entities are not being passed because transactionType is empty. We can probably fix that by getting transactionType from APMServiceContext.

@dgieselaar
Copy link
Member Author

The link on the service map should also be fixed, and possibly other places.

@cauemarcondes
Copy link
Contributor

is it something that ML team recently changed? @sqren fixed some of the ML links on this PR #85976, maybe we missed that.

@dgieselaar
Copy link
Member Author

@cauemarcondes I'm not sure about pause. But we are not passing service.name and transaction.type to the ML link helper function, so that's something that we should fix.

@cauemarcondes
Copy link
Contributor

I fixed to pass the service name and transaction type. But it triggers an infinite loop because we set pause:true, value: 0, this is the default setting defined on kibana advanced settings. On APM we hardcoded pause to false because of this issue, maybe we should do the same here?! cc. @formgeist

@dgieselaar
Copy link
Member Author

@cauemarcondes I think the ML folks will be able to help you here. I just spoke to Dima about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.11.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants