Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Enforce pause when it's set to false with 0 refresh interval #86805

Merged
merged 2 commits into from
Dec 23, 2020
Merged

[ML] Enforce pause when it's set to false with 0 refresh interval #86805

merged 2 commits into from
Dec 23, 2020

Conversation

darnautov
Copy link
Contributor

Summary

Addresses the issue mentioned in #86774 when refreshInterval:(pause:!f,value:0), from the URL caused the infinite loop.

Checklist

@darnautov darnautov added :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v7.12.0 labels Dec 22, 2020
@darnautov darnautov requested a review from a team as a code owner December 22, 2020 17:21
@darnautov darnautov self-assigned this Dec 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

alvarezmelissa87
alvarezmelissa87 approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM ⚡

@qn895
Copy link
Member

qn895 commented Dec 22, 2020

Tested and LGTM 🎉

@dgieselaar dgieselaar mentioned this pull request Dec 23, 2020
Merged
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 7.0MB 7.0MB +29.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@darnautov darnautov merged commit d4d70f2 into elastic:master Dec 23, 2020
@darnautov darnautov deleted the ML-refresh-interval-check branch December 23, 2020 13:01
@darnautov darnautov mentioned this pull request Dec 23, 2020
Merged
darnautov added a commit to darnautov/kibana that referenced this pull request Dec 23, 2020
@darnautov
[ML] Enforce pause when it's set to false with 0 refresh interval (el…
cce969f 
…astic#86805)

* [ML] Enforce pause when it's set to false with 0 refresh interval

* [ML] add mocks, fix unit tests
darnautov added a commit to darnautov/kibana that referenced this pull request Dec 23, 2020
@darnautov
[ML] Enforce pause when it's set to false with 0 refresh interval (el…
260867a 
…astic#86805)

* [ML] Enforce pause when it's set to false with 0 refresh interval

* [ML] add mocks, fix unit tests
This was referenced Dec 23, 2020
Merged
Merged
darnautov added a commit that referenced this pull request Dec 23, 2020
@darnautov
[ML] Enforce pause when it's set to false with 0 refresh interval (#8…
a561a09 
…6805) (#86890)

* [ML] Enforce pause when it's set to false with 0 refresh interval

* [ML] add mocks, fix unit tests
darnautov added a commit that referenced this pull request Dec 23, 2020
@darnautov
[7.10] [ML] Enforce pause when it's set to false with 0 refresh inter…
4cafa58 
…val (#86805)  (#86894)

* [ML] enforce pause

* [ML] move condition
darnautov added a commit that referenced this pull request Dec 23, 2020
@darnautov
[ML] Enforce pause when it's set to false with 0 refresh interval (#8…
8a2d6e6 
…6805) (#86889)

* [ML] Enforce pause when it's set to false with 0 refresh interval

* [ML] add mocks, fix unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson Awaiting requested review from peteharverson

@qn895 qn895 Awaiting requested review from qn895

Assignees

@darnautov darnautov

Labels
:ml release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@darnautov @elasticmachine @qn895 @kibanamachine @alvarezmelissa87