Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] URL Service #87304

Closed
13 tasks done
Tracked by #92603
stacey-gammon opened this issue Jan 5, 2021 · 5 comments
Closed
13 tasks done
Tracked by #92603

[Meta] URL Service #87304

stacey-gammon opened this issue Jan 5, 2021 · 5 comments
Labels
Feature:SharingURLs Short URLs and Share URL features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Meta NeededFor:ML

Comments

@stacey-gammon
Copy link
Contributor

stacey-gammon commented Jan 5, 2021

General

  • Place the new URL Service in src/plugins/share plugin.

Tasks

Architecture review

URL generators 👉 Locators

Short URL service


Part of #92603

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@tsullivan
Copy link
Member

tsullivan commented Jan 7, 2021

Related: Reporting

When there is a request to generate a report, the application captures the current page URL.

Those URLs in Reporting job parameters also have no migration system, and also don't carry any application state except for what is in the query string.

I could see the Reporting integration changing so that when there a request to generate a report, the URL comes from a specialized service.

@streamich
Copy link
Contributor

streamich commented Jan 21, 2021

  • saved object?
    • probably should keep as saved objects
  • migrations?
    • leaning towards supporting migrations in URL service
    • should be linked to report/alert, show be deleted once report/alert is deleted
  • UI?
    • no
  • expiry time?
    • track when link was last visited
  • Plugin contract on browser and server?
    • yes

@streamich streamich changed the title Improved url service URL Service Feb 24, 2021
@streamich streamich added the Feature:SharingURLs Short URLs and Share URL features label Feb 24, 2021
@elastic-jb
Copy link

If we are going to address the ability to remove short URLs, what pieces are still missing to allow a Share-To that can be revoked?

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Apr 26, 2021
@petrklapka petrklapka added 1 and removed 1 labels May 6, 2021
@exalate-issue-sync exalate-issue-sync bot removed the loe:medium Medium Level of Effort label May 6, 2021
@Dosant
Copy link
Contributor

Dosant commented Jun 16, 2021

I wonder if on top of a new URL service / URL locators we could progress on documenting Kibana URLs #4338?

Maybe we could auto-generate a doc page from all the locators' interfaces?
This was probably brought up before but didn't see this mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:SharingURLs Short URLs and Share URL features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Meta NeededFor:ML
Projects
None yet
Development

No branches or pull requests

9 participants