Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry] Move all collection logic to Stats/Usage collectors #89709

Open
afharo opened this issue Jan 29, 2021 · 2 comments
Open

[Telemetry] Move all collection logic to Stats/Usage collectors #89709

afharo opened this issue Jan 29, 2021 · 2 comments
Labels
discuss Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@afharo
Copy link
Member

afharo commented Jan 29, 2021

At the moment, when building the Telemetry payload, on top of retrieving all the Stats and Usage collectors' data, the telemetry plugin appends some data to it. Examples of the latter are Data Telemetry, License data and ES's cluster_stats, Nodes Usage + X-Pack usage.

This issue is to discuss if it's worth moving this logic to their own collectors. IMO, this will help with maintaining the full schema (#83704), and those sources of information can be reused, if needed, by the Suggestion Engine, since they can be called as any other usage/stat collector.

While implementing this, we might want to explore a new API that allows collectors to specify the absolute path where they want to be merged in as needed in #89110.

What do you think?

@afharo afharo added discuss Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Telemetry labels Jan 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@Bamieh
Copy link
Member

Bamieh commented Jan 29, 2021

I think we'd need a small POC for this to decide. The implementation details are the tricky part here which might restrict our options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
Development

No branches or pull requests

3 participants