Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove telemetry_collection_manager in favour of a better X-Pack extension API in the telemetry plugin #93185

Open
afharo opened this issue Mar 2, 2021 · 5 comments
Labels
Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture

Comments

@afharo
Copy link
Member

afharo commented Mar 2, 2021

The reason for telemetry_collection_manager was to provide a set of APIs to add priority-based collection. This helped us to attempt monitoring collection before rolling back to the local (X-Pack or OSS) methods.

Now, monitoring collection doesn't count as a strategy on its own, and X-Pack simply replaces OSS when available. This can be handled in a better way directly in the telemetry plugin, reducing the need for a separate plugin.

@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc enhancement New value added to drive a business result Feature:Telemetry labels Mar 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo afharo added technical debt Improvement of the software architecture and operational architecture and removed enhancement New value added to drive a business result labels Mar 2, 2021
@Bamieh
Copy link
Member

Bamieh commented Mar 4, 2021

We can create a new collector type next to createUsageCollector called createRootCollector or createProductCollector which appends the data to stack_stats.* instead of stack_stats.kibana.plugins.*. Then we can start enforcing schema there too.

Alternatively we can utilize createStatsCollector to achieve this.

@afharo
Copy link
Member Author

afharo commented Mar 4, 2021

I like that idea, but I wonder if it fits best with this other issue #89709. What do you think?

I think for this purpose, we can do something similar to the SavedObjectsClient security extension. We have a defaultFactory for OSS, and X-Pack can extend that defaultFactory. I hope it makes sense.

@Bamieh
Copy link
Member

Bamieh commented Mar 9, 2021

i dont mind it if we come up with a good execution plan. Generally I think we dont really need to complicate thing since our usecase is very simple straightforward in terms of what we want to do between the xpack plugin and the oss one.

@afharo
Copy link
Member Author

afharo commented Feb 16, 2022

After the relicensing, we probably don't need to maintain the X-Pack extension anymore. We could use this issue to migrate the X-Pack specifics to the OSS telemetry, and remove the telemetry_collection_manager plugin entirely.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

3 participants