[alerting] need to use encodeURIComponent() when making http calls with user-data in the path

[pmuellr]

originating from: #97747

In the following code, and other similar places, we aren't encoding the instanceId with encodeURIComponent(), which means if the instanceId contains "problematic" characters for URLs, the request is likely to fail:

kibana/x-pack/plugins/triggers_actions_ui/public/application/lib/alert_api/mute_alert.ts

Lines 10 to 20 in 07c45e1

	export async function muteAlertInstance({
	id,
	instanceId,
	http,
	}: {
	id: string;
	instanceId: string;
	http: HttpSetup;
	}): Promise<void> {
	await http.post(`${BASE_ALERTING_API_PATH}/rule/${id}/alert/${instanceId}/_mute`);
	}

I was able to get this to fail with an alert that generated instanceId's of the form host/1, host/2, and saw 404's being returned when attempting to mute the instance. After adding theencodeURIComponent() wrapper, worked fine.

Rule type ids and connector type ids should not need to be encoded, today, since we are in control of them. However, we probably want to do that anyway, in case we find outselves at a point where users can create new rule types / connector types (eg, via expressions).

Likewise rule ids do not need to be encoded, since we generate them and they're always UUIDs. Connector ids however can be named by a customer for preconfigured connectors, and will need to be encoded. We'll probably end up, someday, having customer-named rule ids, so we should should go ahead and encode those as well.

That implies almost all of our http requests from the web ui should will need this encoding change. Luckily, they seem to all be centralized here:

• x-pack/plugins/triggers_actions_ui/public/application/lib/alert_api
• x-pack/plugins/triggers_actions_ui/public/application/lib/action_connector_api
• x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types/jira/api.ts
• x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types/resilient/api.ts
• x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types/servicenow/api.ts

[elasticmachine]

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)