Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Remove OSS builds #100577

Merged
merged 9 commits into from
Jun 29, 2021
Merged

[build] Remove OSS builds #100577

merged 9 commits into from
Jun 29, 2021

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented May 25, 2021 •
edited
Loading

This removes the oss and no-oss flags from node scripts/builds and
the related build outputs.

@jbudz
[build] Remove OSS builds
4e06693 
This removes the `oss` and `no-oss` flags from `node scripts/builds` and
the related builds.
@jbudz jbudz added Team:Operations Team label for Operations Team v7.14.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels May 25, 2021
@jbudz jbudz marked this pull request as ready for review May 26, 2021 17:00
@jbudz jbudz requested a review from a team as a code owner May 26, 2021 17:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

mistic
mistic approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbudz
Copy link
Member Author

jbudz commented May 26, 2021

Merge pending - waiting for #99980

@jbudz
Copy link
Member Author

jbudz commented Jun 1, 2021

@elasticmachine merge upstream

@jbudz
Copy link
Member Author

jbudz commented Jun 17, 2021

I'll reopen this when we're ready for it.

@jbudz jbudz closed this Jun 17, 2021
@tylersmalley tylersmalley reopened this Jun 23, 2021
@tylersmalley
Copy link
Contributor

@elasticmachine merge upstream

@tylersmalley
Copy link
Contributor

We're ready - the backport was merged into 7.x

@tylersmalley
Copy link
Contributor

@elasticmachine merge upstream

@jbudz
Copy link
Member Author

jbudz commented Jun 24, 2021

🎈 is anyone able to do a pass with this up to date again?

@jbudz
Copy link
Member Author

jbudz commented Jun 28, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz added the auto-backport Deprecated: Automatically backport this PR after it's merged label Jun 29, 2021
@jbudz jbudz merged commit b2d76a6 into elastic:master Jun 29, 2021
@jbudz jbudz deleted the build/rm-oss branch June 29, 2021 14:22
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 100577

@jbudz jbudz added backport pending and removed auto-backport Deprecated: Automatically backport this PR after it's merged labels Jun 29, 2021
@jbudz jbudz mentioned this pull request Jun 29, 2021
Closed
jbudz added a commit that referenced this pull request Jun 29, 2021
@jbudz
Revert "[build] Remove OSS builds (#100577)"
24661fe 
This reverts commit b2d76a6.
jbudz added a commit to jbudz/kibana that referenced this pull request Jun 29, 2021
@jbudz
Revert "Revert "[build] Remove OSS builds (elastic#100577)""
865ec52 
This reverts commit 24661fe.
@jbudz jbudz mentioned this pull request Jun 29, 2021
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 30, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 100577 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 30, 2021
@jbudz
Copy link
Member Author

jbudz commented Jun 30, 2021

Backported by #103792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

@mistic mistic mistic approved these changes

Assignees
No one assigned
Labels
backported release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jbudz @elasticmachine @tylersmalley @kibanamachine @spalger @mistic