Fixing typo in tag cloud warning message #10092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
Feature:Visualizations
ycombinator
changed the title
debadair
approved these changes
Jan 27, 2017
| @@ -2,6 +2,6 @@ | |||
| <div ng-show="vis.params.hideLabel" class="tagcloud-custom-label"></div> | |||
| <div class="tagcloud-notifications"> | |||
| <div class="tagcloud-truncated-message">The number of tags has been truncated to avoid long draw times.</div> | |||
| <div class="tagcloud-incomplete-message">The container is too small to display the entire cloud. Tags may appear cropped or be ommitted.</div> | |||
| <div class="tagcloud-incomplete-message">The container is too small to display the entire cloud. Tags may appear cropped or be omitted.</div> | |||
There was a problem hiding this comment.
The fix LGTM. I tripped a little over the "may appear" -- I'd probably go with "Tags might be cropped or omitted." But truthfully, that's just a style preference.
There was a problem hiding this comment.
I will gladly defer to you on all things language 😄. Updating...
ycombinator
added a commit
that referenced
this pull request
Jan 30, 2017
* Fixing typo * Simplifying language
ycombinator
added a commit
that referenced
this pull request
Jan 30, 2017
* Fixing typo * Simplifying language
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the spelling of "omitted" in the tag cloud visualization.