Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest pipelines] add extract_device_type to user agent processor #100986

Merged
merged 8 commits into from Jun 24, 2021
Merged

[Ingest pipelines] add extract_device_type to user agent processor #100986

merged 8 commits into from Jun 24, 2021

Conversation

sabarasaba
Copy link
Member

Fixes: #97466

Release Note

Add support to the new extract_device_type option that was added to the user agent processor.

image

@sabarasaba sabarasaba added release_note:enhancement v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Ingest Node Pipelines Ingest node pipelines management v7.14.0 labels May 31, 2021
@sabarasaba sabarasaba requested a review from a team as a code owner May 31, 2021 09:38
@sabarasaba sabarasaba self-assigned this May 31, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@sabarasaba sabarasaba marked this pull request as draft May 31, 2021 10:41
@sabarasaba sabarasaba removed the request for review from alisonelizabeth May 31, 2021 10:48
@sabarasaba sabarasaba marked this pull request as ready for review May 31, 2021 13:07
alisonelizabeth
alisonelizabeth reviewed Jun 1, 2021
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @sabarasaba! Tested locally and works great. I left a couple minor comments/questions in the code.

Also, were you able to follow up with the ES team regarding #97466 (comment)? Just want to make sure this can be safely backported. Thanks!

...ents/pipeline_editor/components/processor_form/processors/common_fields/properties_field.tsx Show resolved Hide resolved
...c/application/components/pipeline_editor/components/processor_form/processors/user_agent.tsx Outdated Show resolved Hide resolved
...c/application/components/pipeline_editor/components/processor_form/processors/user_agent.tsx Outdated Show resolved Hide resolved
...c/application/components/pipeline_editor/components/processor_form/processors/user_agent.tsx Outdated Show resolved Hide resolved
...c/application/components/pipeline_editor/components/processor_form/processors/user_agent.tsx Outdated Show resolved Hide resolved
@sabarasaba
Copy link
Member Author

@alisonelizabeth They forgot to backport the docs for 7.13, but they say they will do it soon!

alisonelizabeth
alisonelizabeth approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @sabarasaba. I'm going to go ahead and approve to unblock you. Happy to see the EUI changes will be merged soon and we won't need the hack!

@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ingestPipelines 687.1KB 688.6KB +1.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

@sabarasaba sabarasaba merged commit 4c2449f into elastic:master Jun 24, 2021
@sabarasaba sabarasaba mentioned this pull request Jun 24, 2021
Merged
sabarasaba added a commit to sabarasaba/kibana that referenced this pull request Jun 24, 2021
@sabarasaba
[Ingest pipelines] add extract_device_type to user agent processor (e…
eda1dfb 
…lastic#100986)

* testing layouts

* fix copy for beta badge

* replace hardcoded text with i18n strings

* avoid updating types and just replace label

* Small cr changes

* get rid of style prop and just use a smaller badge
sabarasaba added a commit that referenced this pull request Jun 24, 2021
@sabarasaba
[Ingest pipelines] add extract_device_type to user agent processor (#…
a3e8360 
…100986) (#103226)

* testing layouts

* fix copy for beta badge

* replace hardcoded text with i18n strings

* avoid updating types and just replace label

* Small cr changes

* get rid of style prop and just use a smaller badge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

Assignees

@sabarasaba sabarasaba

Labels
Feature:Ingest Node Pipelines Ingest node pipelines management release_note:enhancement Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Ingest Node Pipelines] Add extract_device_type option to user agent processor
4 participants
@sabarasaba @elasticmachine @kibanamachine @alisonelizabeth