Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Fix editor react error on configuration panel #101367

Merged
merged 3 commits into from
Jun 7, 2021
Merged

[Lens] Fix editor react error on configuration panel #101367

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f14c2c6
:bug: Fix react error
dej611 Jun 4, 2021
46851e8
:ok_hand: Apply feedback
dej611 Jun 4, 2021
39dfd5f
Merge branch 'master' into lens/fix-advanced-options-error
kibanamachine Jun 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/advanced_options.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,10 @@ export function AdvancedOptions(props: {
<>
<EuiSpacer size="s" />
{inlineOptions.map((option, index) => (
<>
<React.Fragment key={option.dataTestSubj}>
{React.cloneElement(option.inlineElement!, { key: option.dataTestSubj })}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This can be simplified to

{option.inlineElement}

now

{index !== inlineOptions.length - 1 && <EuiSpacer size="s" />}
</>
</React.Fragment>
))}
</>
)}
Expand Down