Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): moving @kbn/cli-dev-mode into bazel #103067

Merged
merged 5 commits into from
Jun 24, 2021
Merged

chore(NA): moving @kbn/cli-dev-mode into bazel #103067

merged 5 commits into from
Jun 24, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Jun 23, 2021

One step forward on #69706

That PR moves the @kbn/cli-dev-mode into Bazel by pushing a BUILD file for that package.
After merging this the package will be consumed from within bazel-bin folder.

@mistic mistic added auto-backport Deprecated: Automatically backport this PR after it's merged chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.0 v8.0.0 labels Jun 23, 2021
@mistic mistic marked this pull request as ready for review June 23, 2021 11:49
@mistic mistic requested a review from a team as a code owner June 23, 2021 11:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic mistic requested a review from jbudz June 23, 2021 11:49
@mistic mistic enabled auto-merge (squash) June 23, 2021 12:06
@mistic
Copy link
Member Author

mistic commented Jun 23, 2021

@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Jun 24, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 17adfac into elastic:master Jun 24, 2021
@kibanamachine kibanamachine mentioned this pull request Jun 24, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 24, 2021
@mistic @kibanamachine
chore(NA): moving @kbn/cli-dev-mode into bazel (elastic#103067)
7715a3b 
* chore(NA): moving @kbn/cli-dev-mode into bazel

* chore(NA): merge and solve conflicts with master
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 24, 2021
@kibanamachine @mistic
chore(NA): moving @kbn/cli-dev-mode into bazel (#103067) (#103201)
9fb76c6 
* chore(NA): moving @kbn/cli-dev-mode into bazel

* chore(NA): merge and solve conflicts with master

Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
@mistic mistic mentioned this pull request Jul 1, 2021
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mistic @elasticmachine @kibanamachine @jbudz