Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Search] Success toast polish pass #103410

Merged
merged 13 commits into from
Jun 28, 2021
Merged

Commits on Jun 26, 2021

  1. Fix toasts rerendering/resetting between page navigations + z-index i…

    …ssues
    
    - note: I opted to delete the `<Callouts>` component in favor of just reverting it to the old `<FlashMessages>`, now that FlashMessages is no longer responsible for toasts
    cee-chen committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    04da1fb View commit details
    Browse the repository at this point in the history
  2. Update engine creation success messages

    - to use a toast instead of a callout
    - update copy to match EUI guidelines
    cee-chen committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    1542304 View commit details
    Browse the repository at this point in the history
  3. Update engine deletion success message

    - to use a toast instead of a callout
    - update copy to match EUI guidelines
    cee-chen committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    6d08e1e View commit details
    Browse the repository at this point in the history
  4. Update source engines add/delete success messages

    - to use a toast instead of a callout
    - update copy to match EUI guidelines
    cee-chen committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    2881a26 View commit details
    Browse the repository at this point in the history
  5. Update crawler domain delete message

    - to use a toast instead of a callout
    - update copy to match EUI guidelines
    cee-chen committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    2c02aba View commit details
    Browse the repository at this point in the history
  6. Update API key create/update/delete sucess messages

    - to use a toast instead of a callout
    - update copy to match EUI guidelines
    cee-chen committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    eadc068 View commit details
    Browse the repository at this point in the history
  7. Update curations delete success message

    - to use a toast instead of a callout
    - update copy to match EUI guidelines
    cee-chen committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    b8fe43d View commit details
    Browse the repository at this point in the history
  8. Update results settings success message

    - to use a toast instead of a callout
    - update copy to match EUI guidelines
    cee-chen committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    6c20f65 View commit details
    Browse the repository at this point in the history
  9. Update relevance tuning success/reset messages

    - to use a toast (+ toast message) instead of a callout
    - update copy to match EUI guidelines
    cee-chen committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    f8f8696 View commit details
    Browse the repository at this point in the history
  10. Update document deletion success message

    - to use a toast instead of a callout (+ split additional text)
    - update copy to match EUI guidelines
    cee-chen committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    8f5957c View commit details
    Browse the repository at this point in the history
  11. Update role mappings create/update/delete success messages

    - to use a toast instead of a callout
    - update copy to match EUI guidelines
    cee-chen committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    2dc4826 View commit details
    Browse the repository at this point in the history
  12. Run i18n_check --fix

    - per localization team guidelines - strings that have been changed should get deleted/scheduled to be re-translated
    cee-chen committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    b934dc0 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2021

  1. Configuration menu
    Copy the full SHA
    54c74ec View commit details
    Browse the repository at this point in the history