Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Discover] Replace doc viewer table with EuiInMemoryTable (#102149) #103678

Merged
merged 2 commits into from
Jul 1, 2021

Conversation

dimaanj
Copy link
Contributor

@dimaanj dimaanj commented Jun 29, 2021

Backports the following commits to 7.x:

…2149)

* [Discover] replace legacy table with euiInMemoryTable

* [Discover] update styles, add badge

* fix font in badge and adjust line height

* add tooltip

* [Discover] update unit tests, return actions column to left side

* [Discover] update field name test snapshot

* [Discover] update wording

* [Discover] handle pagination, return formatting value styles

* [Discover] fix failing stylelint error

* [Discover] return responsive prop, update classes

* [Discover] update test and meet formatting rules

* improve table view on medium

* remove extra file

* [Discover] fix unit test

* [Discover] align top vertically field name and action cells, disable table responsive design

* [Discover] adjust styles for cross browser compatibility

* [Discover] remove pagination optimize styles, update test

* [Discover] fix eslint

* [Discover] clean up styles

* [Discover] fix single doc view

* [Discover] add check lack of multifieldBadge

Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@dimaanj dimaanj enabled auto-merge (squash) June 29, 2021 14:42
@timroes
Copy link
Contributor

timroes commented Jun 29, 2021

@elasticmachine run elasticsearch-ci/docs

@dimaanj
Copy link
Contributor Author

dimaanj commented Jul 1, 2021

@elasticmachine merge upstream

@dimaanj dimaanj merged commit 0e42013 into elastic:7.x Jul 1, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
discover 366 377 +11

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 428.1KB 421.8KB -6.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 88.3KB 93.0KB +4.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants