Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector map #10448

Closed
wants to merge 150 commits into from
Closed

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Feb 17, 2017

WIP


This PR is a spin-off from #10131. Using a feature branch so we can manage two parallel PRs


The scope of this PR is the introduction of the vector map, which includes some map enhancements that will benefit both TileMap and VectorMap.


other todos:

  • make vector maps configurable in .yml
  • add labeling to choropleth maps (just tooltips now, would need ot use L.label plugin due to dependency on leaflet 0.7)
  • update test code
  • provide better default data (add more join-fields)
  • multi tile-map, which was deprecated, is now fully disabled. Perhaps we should re-evaluate this.

Other enhancements/bug fixes will get their own PR. Forthcoming.

stacey-gammon and others added 22 commits February 14, 2017 15:35
…c#10346)

* Acknowledge doc_table:highlight config even after init

* Use highlightAll on dashboard
* Fix CheckBox alignment by applying box-sizing: border-box to all before and after pseudo-elements.

* Fix ToolBarSearchBox height and icon alignment.

* Make Table examples consistently use the cell liner.
…g tables. (elastic#10358)

* Fix position of button tooltips in the Dashboard and Visualize listing tables.

* Remove redundant CSS from ToolBarSearch.
* adding vislib chart grid

* updating vislib to correctly render all new features

* adding new options to kibana visualizations

* update vis icon on save

* updating documentation

* fixing unit tests

* cleaning up

* updating based on UI review

* adding visualize editor unit tests

* selenium tests

* additional option tabs

* some more changes to the tabs/options [thanks CJ]

* going back from Category/Value axis to X/Y axis

* fixing unselected dropdown options

* updating based on last UI review

* updating based on last review

* updating based on last review

* fixing issue with axis titles

* allowing to specify only upper or only lower data bound

* updating based on brandons review

* fixing horizontal bar chart labels

* fixing test

* adding backward compatibility

* updating based on last review

* fixing selenium tests
* fixing broken group bar chart

* fixing test

* updating based on last review
elastic#10033)

* extracting to parent agg helper

* adding comulative sum agg

* adding serial diff and moving avg

* adding tests
…lastic#10275)

* [optimizer] use "unsafe" defaults that have proven to be safe enough

* [docs] add a note to the CONTRIBUTING.md regarding potential pitfalls
* fixing pie chart tooltip custom label bug

* fixing the bug thomas found
* [status] Only provide latest metrics

* [status] Snake case requests object

* [status] Add build snapshot flag, last updated time

* [status] Re-add requests per second

* [status] Add uptime

* [status] collection_time -> collection_interval, add memory object

* [status] Add api tests

* [status] Add breaking changes docs

* [status] Remove metrics config

* [status] nest load under cpu, shorten memory and average

* [status] collection_time -> collection_interval

* [status api] Unnest heap, rename load to load average
* [build] Add notice file

* [build] Include license text if available

* [build] Look for both license and notice files

* [build] Add node license to notice

* [build] Add a base notice file including info on committed dependencies

* Bump license copyright year

* [build] Kibana at top of notice
…ths, regardless of cell content. (elastic#10378)

* Adjust Table component styles and markup to maintain fixed column widths, regardless of cell content.
- Fix ellipsis-truncation of text in IE11 and Edge.
- Update Visualize landing table markup.

* Update Dashboard landing table and Saved Objects table with cell liner markup.
The inline filters are now hidden when no `filter` property has been
passed to the row directive, which is more consistent with the filters
in the document details table. The context view relies on this behaviour
to hide the filtering actions.

Improving the `inlineFilter` to actually re-use the passed `filter`
function happens in elastic#10395.
* [plugin cli] Fix file:/// paths on Windows

* [plugin cli] Stricter path checking, keeps support for file://

* [plugin cli] Add deprecation warning for file://
Re-using the passed filter function improves consistency with the
implementation of the filters in the document details table.
…#10392)

* [courier] resolve looper iteration when requests are aborted

The search looper returns the promise from search executions to ensure that subsequent loops do not run until the previous loop has completed. This causes the looper to get stuck when all of the aborted requests are completed, as completed requests do not resolve or reject their promises, causing the looper to never allow another search loop. Since this behavior is desirable for pages where we don't want to execute the `.then()` or `.catch()` callbacks for requests that were aborted, we work around it in this specific case by creating a promise that is resolved when each request is either aborted or completed.

* [ui/promises] add Promise.race() method to Promises util

* [courier/request] use angular promises in courier

* [courier/looper] no single-letter variables

* [ui/promises] add tests for Promise.race()
* Adding attributes to be used by sharing

* Moving the shared-item tags for dashboard panels

* Switching from shared-item-title/description to just title/description

* Removing move noise

* Fixing typo

* Adding data- prefix before attributes, began writing tests

Adding shared-item title tests

Switching up the panel tests

Adding description tests

Fixing linting

Adding dashboard timefilter test

Adding visualization shared-item tests

Adding shared-timefilter tests

Adding discover shared-item tests

* Fixing shared-items-count on dashboard

* Fixing functional test data for discover and visualize
@tbragin tbragin added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Feb 17, 2017
cjcenizal and others added 2 commits February 17, 2017 16:13
…act Components directly. (elastic#10259)

* Migrate from a handrolled interface for building examples to using React Components directly.
* Wrap components with containers instead of passing down state and actions via context.
…earch to false (elastic#9658)

* only watch searchSource when vis requires search

* add test
@tbragin
Copy link
Contributor

tbragin commented Feb 21, 2017

@thomasneirynck What values can I use against this map? Doesn't seem to be working for me using a 2-letter country code.

Also, is this a WIP PR or is it ready for review?

screen shot 2017-02-20 at 4 23 43 pm

@thomasneirynck
Copy link
Contributor Author

@tbragin it is currently broken. sorry about that, working on getting it back up..

@thomasneirynck
Copy link
Contributor Author

Going to close this and reopen against master. At this point, we can do without the feature branch as experimentation phase is over.

@thomasneirynck
Copy link
Contributor Author

closing in favor of #10824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v5.4.0 v6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet