[Vislib XY axis] Adds a deprecation notice in the UI and a docs section #105055

stratoula · 2021-07-09T12:57:38Z

Summary

It adds a notification on the vislib XY axis charts. The notification is only visible on the editor and not on the dashboard.

Part of #103209

Documentation preview https://kibana_105055.docs-preview.app.elstc.co/guide/en/kibana/master/add-aggregation-based-visualization-panels.html#new-charts-library

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

stratoula · 2021-07-09T13:12:43Z

src/plugins/visualize/public/application/components/visualize_editor_common.tsx

 import {
  SavedVisInstance,
  VisualizeAppState,
  VisualizeAppStateContainer,
  VisualizeEditorVisInstance,
 } from '../types';
+import { getUISettings } from '../../services';
+
+const LEGACY_CHARTS_LIBRARY = 'visualization:visualize:legacyChartsLibrary';


I don't import it from xy plugin because it creates a cyclic dependency. As this code and setting is going to removed in the next minor, I think it is ok.

stratoula · 2021-07-09T15:45:29Z

@elasticmachine merge upstream

stratoula · 2021-07-12T07:53:27Z

@elasticmachine merge upstream

elasticmachine · 2021-07-12T13:07:31Z

Pinging @elastic/kibana-app (Team:KibanaApp)

stratoula · 2021-07-12T13:10:24Z

@gchaps @KOTungseth I need your help on this.
I added a notification on the vislib XY axis charts, that are going to be removed in 7.16. I want to inform the users about the removal and suggest them to turn the setting off (if they are still using the old implementation)
If they don't do it, on 7.16 they will automatically switch to the new implementation.

Moreover, I added some documentation explaining the advantages of the new implementation. I would love your feedback on the UI text and the documentation added.

docs/user/dashboard/aggregation-based.asciidoc

src/plugins/visualize/public/application/components/deprecation_vis_warning.tsx

src/plugins/visualize/public/application/components/visualize_editor_common.tsx

stratoula · 2021-07-13T07:17:06Z

@wylieconlon @gchaps
I applied Wylie's comments but I would like to also inform the users who don't have the permissions to edit the advanced settings.(This also agrees with our documentation for vislib deprecation) I know that the text needs refinement so I would like your feedback here.

User has the permissions. I have added one link to the advanced settings switch and one to our documentation.

User without permissions. Only link to the documentation and a message to contact the administrator.

docs/user/dashboard/aggregation-based.asciidoc

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

stratoula · 2021-07-14T10:26:02Z

@elasticmachine merge upstream

stratoula · 2021-07-15T07:34:00Z

@gchaps and @KOTungseth thank you! It is much better now! I removed all the changes I made on the aggregation-based section and moved them as Gail suggested on the advanced settings page.

Here are the screenshots of the UI notification:

stratoula · 2021-07-19T06:19:22Z

@elasticmachine merge upstream

wylieconlon

Haven't run the code, but changes LGTM.

src/plugins/visualize/public/application/components/deprecation_vis_warning.tsx

gchaps · 2021-07-19T19:38:46Z

Re: the warning, since Advanced Settings is a feature, it should use title case.

kibanamachine · 2021-07-20T10:32:46Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`visualize`	79	80	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`visualize`	92.0KB	94.0KB	+2.1KB

History

💛 Build #139618 was flaky 54f8a76
💚 Build #139253 succeeded bf1c8a9
💚 Build #138669 succeeded 72385bb
💚 Build #138403 succeeded 1e27006
💚 Build #138353 succeeded f12a87c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…on (elastic#105055) * [Vislib XY axis] Adds a deprecation notice in the UI and a docs section * Remove cyclic dependency * Fix link * Add functional test * fix functional tests * Apply PR comments * Update docs/user/dashboard/aggregation-based.asciidoc Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> * Apply PR changes * minor * Change the implementation * Use title calse in Advanced Settings Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

…on (#105055) (#106221) * [Vislib XY axis] Adds a deprecation notice in the UI and a docs section * Remove cyclic dependency * Fix link * Add functional test * fix functional tests * Apply PR comments * Update docs/user/dashboard/aggregation-based.asciidoc Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> * Apply PR changes * minor * Change the implementation * Use title calse in Advanced Settings Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

stratoula added 2 commits July 9, 2021 15:52

[Vislib XY axis] Adds a deprecation notice in the UI and a docs section

b41daa4

Remove cyclic dependency

931fa30

stratoula commented Jul 9, 2021

View reviewed changes

Fix link

4547f62

kibanamachine and others added 2 commits July 9, 2021 11:45

Merge branch 'master' into xy-axis-removal-notfication

17f037a

Add functional test

194df35

kibanamachine and others added 2 commits July 12, 2021 03:53

Merge branch 'master' into xy-axis-removal-notfication

96145b5

fix functional tests

44e62ec

stratoula added Feature:XYAxis XY-Axis charts (bar, area, line) v7.15.0 v8.0.0 release_note:enhancement docs Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 12, 2021

stratoula marked this pull request as ready for review July 12, 2021 13:07

stratoula requested a review from a team July 12, 2021 13:07

stratoula requested a review from a team as a code owner July 12, 2021 13:07

stratoula added this to In progress in Legacy visualizations via automation Jul 12, 2021

mshustov approved these changes Jul 12, 2021

View reviewed changes

wylieconlon suggested changes Jul 12, 2021

View reviewed changes

Apply PR comments

f3a93e1

KOTungseth reviewed Jul 13, 2021

View reviewed changes

docs/user/dashboard/aggregation-based.asciidoc Outdated Show resolved Hide resolved

docs/user/dashboard/aggregation-based.asciidoc Outdated Show resolved Hide resolved

Update docs/user/dashboard/aggregation-based.asciidoc

f12a87c

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

Merge branch 'master' into xy-axis-removal-notfication

1e27006

stratoula added 2 commits July 15, 2021 10:29

Apply PR changes

e0dbc45

minor

72385bb

KOTungseth approved these changes Jul 15, 2021

View reviewed changes

Merge branch 'master' into xy-axis-removal-notfication

bf1c8a9

wylieconlon approved these changes Jul 19, 2021

View reviewed changes

src/plugins/visualize/public/application/components/deprecation_vis_warning.tsx Outdated Show resolved Hide resolved

stratoula added 2 commits July 20, 2021 09:45

Change the implementation

54f8a76

Use title calse in Advanced Settings

dc8878b

stratoula merged commit 8b2ceae into elastic:master Jul 20, 2021

Legacy visualizations automation moved this from In progress to Done Jul 20, 2021

stratoula mentioned this pull request Jul 20, 2021

[7.x] [Vislib XY axis] Adds a deprecation notice in the UI and a docs section (#105055) #106221

Merged

stratoula mentioned this pull request Sep 6, 2021

[Pie] Remove the legacy pie chart #111246

Closed

stratoula mentioned this pull request Nov 1, 2021

[Timelion] Remove the legacy timelion chart (flot) #116915

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Vislib XY axis] Adds a deprecation notice in the UI and a docs section #105055

[Vislib XY axis] Adds a deprecation notice in the UI and a docs section #105055

stratoula commented Jul 9, 2021 •

edited

Loading

stratoula Jul 9, 2021

stratoula commented Jul 9, 2021

stratoula commented Jul 12, 2021

elasticmachine commented Jul 12, 2021

stratoula commented Jul 12, 2021

stratoula commented Jul 13, 2021 •

edited

Loading

stratoula commented Jul 14, 2021

stratoula commented Jul 15, 2021

stratoula commented Jul 19, 2021

wylieconlon left a comment

gchaps commented Jul 19, 2021

kibanamachine commented Jul 20, 2021

[Vislib XY axis] Adds a deprecation notice in the UI and a docs section #105055

[Vislib XY axis] Adds a deprecation notice in the UI and a docs section #105055

Conversation

stratoula commented Jul 9, 2021 • edited Loading

Summary

Checklist

stratoula Jul 9, 2021

Choose a reason for hiding this comment

stratoula commented Jul 9, 2021

stratoula commented Jul 12, 2021

elasticmachine commented Jul 12, 2021

stratoula commented Jul 12, 2021

stratoula commented Jul 13, 2021 • edited Loading

stratoula commented Jul 14, 2021

stratoula commented Jul 15, 2021

stratoula commented Jul 19, 2021

wylieconlon left a comment

Choose a reason for hiding this comment

gchaps commented Jul 19, 2021

kibanamachine commented Jul 20, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

stratoula commented Jul 9, 2021 •

edited

Loading

stratoula commented Jul 13, 2021 •

edited

Loading