Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[maps] show actionable message when term joins have no matches #105161

Merged
merged 11 commits into from Jul 14, 2021
Merged

[maps] show actionable message when term joins have no matches #105161

merged 11 commits into from Jul 14, 2021

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jul 9, 2021 •
edited

fixes #105103

Screen Shot 2021-07-09 at 4 36 05 PM

@nreese nreese added release_note:enhancement [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.15.0 labels Jul 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese
Copy link
Contributor Author

nreese commented Jul 9, 2021

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Jul 12, 2021

@elasticmachine merge upstream

@nreese nreese requested a review from gchaps July 12, 2021 14:21
thomasneirynck
thomasneirynck reviewed Jul 12, 2021
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a real nice UX-improvement. It's something the region-maps used to have :)

Any thoughts on how to add test coverage? e.g. tiled_vector_layer and vector_tile_layer both use VectorLayer#syncData with mock-SyncContext. imho, could introduce something similar for VectorLayer#syncData.

x-pack/plugins/maps/public/classes/layers/vector_layer/vector_layer.tsx Outdated Show resolved Hide resolved
@nreese
Copy link
Contributor Author

nreese commented Jul 12, 2021

Any thoughts on how to add test coverage? e.g. tiled_vector_layer and vector_tile_layer both use VectorLayer#syncData with mock-SyncContext. imho, could introduce something similar for VectorLayer#syncData.

_performInnerJoins does not use anything from the instance. The easiest way to test would just be to move the function out of the class and then test it in isolation

@gchaps
Copy link
Contributor

gchaps commented Jul 12, 2021

How about moving the reason for the error closer to the top:

Unable to perform term join. The left field does not match the right field. Left field: iso_3166-2 has values US-MI, UsVI..... Right field: st has values TX, KKS, OK, FL, ......

@nreese
Copy link
Contributor Author

nreese commented Jul 13, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
maps 742 743 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 3.1MB 3.1MB +2.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

thomasneirynck
thomasneirynck approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

real nice win for the user 💯

@nreese nreese added the auto-backport Deprecated: Automatically backport this PR after it's merged label Jul 14, 2021
@nreese nreese merged commit e74c8ee into elastic:master Jul 14, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 14, 2021
@nreese @kibanamachine
[maps] show actionable message when term joins have no matches (elast…
f626460 
…ic#105161)

* [maps] show actionable message when term joins have no matches

* include message about showing first 10

* fix formatting

* review feedback

* review feedback

* move performInnerJoins into its own function

* lint

* unit test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Jul 14, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 14, 2021
@kibanamachine @nreese
[maps] show actionable message when term joins have no matches (#105161…
dcdb652 
…) (#105588)

* [maps] show actionable message when term joins have no matches

* include message about showing first 10

* fix formatting

* review feedback

* review feedback

* move performInnerJoins into its own function

* lint

* unit test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

@gchaps gchaps Awaiting requested review from gchaps

Assignees
No one assigned
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:enhancement v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[maps] provide feedback when term join fails to find any matches
5 participants
@nreese @elasticmachine @gchaps @kibanamachine @thomasneirynck