Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Anomaly Detection explorer: ensure geo points show up in embeddable map chart area #105671

Merged
merged 1 commit into from Jul 15, 2021
Merged

[ML] Anomaly Detection explorer: ensure geo points show up in embeddable map chart area #105671

merged 1 commit into from Jul 15, 2021

Conversation

alvarezmelissa87
Copy link
Contributor

Summary

Fixes #101344

No longer relies solely on the detector label to determine if a job has relevant geo data for charts.

Checklist

Delete any items that are not applicable to this PR.

  • Unit or functional tests were updated or added to match the most common scenarios
  • Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
  • Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)

@alvarezmelissa87 alvarezmelissa87 self-assigned this Jul 14, 2021
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner July 14, 2021 20:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895
Copy link
Member

qn895 commented Jul 14, 2021

Code LGTM 🎉

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.9MB 5.9MB +123.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

peteharverson
peteharverson approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@alvarezmelissa87 alvarezmelissa87 merged commit 75e6b87 into elastic:master Jul 15, 2021
This was referenced Jul 15, 2021
Merged
Merged
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Jul 15, 2021
@alvarezmelissa87
check metric function as well as label to determine geo (elastic#105671)
a1dd40c
@alvarezmelissa87 alvarezmelissa87 deleted the ml-ad-missing-map-points branch July 15, 2021 14:46
alvarezmelissa87 added a commit that referenced this pull request Jul 15, 2021
@alvarezmelissa87
check metric function as well as label to determine geo (#105671) (#1…
41d70a4 
…05777)
alvarezmelissa87 added a commit that referenced this pull request Jul 15, 2021
@alvarezmelissa87
check metric function as well as label to determine geo (#105671) (#1…
eb678a0 
…05776)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@qn895 qn895 qn895 approved these changes

@walterra walterra Awaiting requested review from walterra

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels
Feature:Anomaly Detection ML anomaly detection :ml release_note:fix v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Points missing from map in Anomaly Explorer
6 participants
@alvarezmelissa87 @elasticmachine @qn895 @kibanamachine @peteharverson @wylieconlon