Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Define color for XHR timings in waterfall chart #105817

Merged
merged 1 commit into from Jul 15, 2021
Merged

[Synthetics] Define color for XHR timings in waterfall chart #105817

merged 1 commit into from Jul 15, 2021

Conversation

justinkambic
Copy link
Contributor

Summary

Resolves #105529

We noticed that the colors being generated for XHR timings in the Synthetics waterfall chart were incorrect and confusing.

This is happening because one of the values in the enumerable set of mime_types we support has no color defined. This change will make the XHR type use the same color we already use for Other.

Testing

Make sure that an XHR timing has the same color as Other.

@justinkambic justinkambic added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability polish v7.14.0 v7.15.0 labels Jul 15, 2021
@justinkambic justinkambic self-assigned this Jul 15, 2021
@justinkambic justinkambic requested a review from a team as a code owner July 15, 2021 17:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

vigneshshanmugam
vigneshshanmugam approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 949.7KB 949.8KB +18.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @justinkambic

@justinkambic justinkambic added release_note:fix auto-backport Deprecated: Automatically backport this PR after it's merged labels Jul 15, 2021
@justinkambic justinkambic merged commit cba23c1 into elastic:master Jul 15, 2021
@justinkambic justinkambic deleted the 105529/waterfall-network-timing-xhr-color-mismatch branch July 15, 2021 20:18
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 15, 2021
@justinkambic @kibanamachine
Define color for XHR timings in waterfall chart. (elastic#105817)
234d9f9
@kibanamachine kibanamachine mentioned this pull request Jul 15, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 15, 2021
@justinkambic @kibanamachine
Define color for XHR timings in waterfall chart. (elastic#105817)
3887fae
@kibanamachine kibanamachine mentioned this pull request Jul 15, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 15, 2021
@kibanamachine @justinkambic
Define color for XHR timings in waterfall chart. (#105817) (#105844)
23f301a 
Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 15, 2021
@kibanamachine @justinkambic
Define color for XHR timings in waterfall chart. (#105817) (#105845)
631322d 
Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

Assignees

@justinkambic justinkambic

Labels
auto-backport Deprecated: Automatically backport this PR after it's merged bug Fixes for quality problems that affect the customer experience polish release_note:fix Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Uptime] waterfall chart network timing sequence is incorrect
4 participants
@justinkambic @elasticmachine @kibanamachine @vigneshshanmugam