Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where loaded event is not sent when no user ID #106090

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

joshdover
Copy link
Contributor

Summary

Follow up to #102390

Fixes code that was returning early when no user ID was available. This ensures that the loaded event is still sent. Only applies to Elastic Cloud deployments where this is enabled.

@joshdover joshdover added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v7.15.0 labels Jul 19, 2021
@joshdover joshdover requested a review from a team as a code owner July 19, 2021 13:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@joshdover joshdover added the auto-backport Deprecated: Automatically backport this PR after it's merged label Jul 19, 2021
@joshdover joshdover enabled auto-merge (squash) July 19, 2021 13:03
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we should also have a test that will ensure this bug doesn't happen again. I'm not exactly sure where to add that, besides maybe trying to add one to the cloud_integration test we recently enabled?
I don't have access to the FS test account anymore and could only do a quick code review.
The bug fix itself LGTM, we can discuss adding a test as a follow up.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloud 17.1KB 17.1KB -6.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.14
7.x

The backport PRs will be merged automatically after passing CI.

@joshdover
Copy link
Contributor Author

Ideally, we should also have a test that will ensure this bug doesn't happen again. I'm not exactly sure where to add that, besides maybe trying to add one to the cloud_integration test we recently enabled?
I don't have access to the FS test account anymore and could only do a quick code review.
The bug fix itself LGTM, we can discuss adding a test as a follow up.

I'm actually not sure a good way to test this. There is a user event API available, but in this case we can't use it directly because we don't have a user ID to hit the API with. It's possible there's some workaround or we can try to go the mocking route which is likely easier.

kibanamachine added a commit that referenced this pull request Jul 19, 2021
…6114)

Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Jul 19, 2021
…6115)

Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants