[Dashboard] Index Pattern Observable Error Handling #106155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssues when embeddables do not load
ThomThomson
added
Feature:Dashboard
|
@elasticmachine merge upstream |
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Dosant
approved these changes
Jul 21, 2021
| ) | ||
| ), | ||
| // Embeddables often throw errors into their output streams. | ||
| catchError(() => EMPTY) |
There was a problem hiding this comment.
nit: I'd move this to a specific child's observable instead:
switchMap((newChildIds: string[]) =>
merge(...newChildIds.map((childId) => dashboardContainer!.getChild(childId).getOutput$().pipe(catchError(() => EMPTY))))
),
I don't think there is a functional difference in how the whole pipe works, but semantically I think this would make more sense as we want to mute errors from a specific output
There was a problem hiding this comment.
This does make a lot more sense, I have moved the catchError into the embeddable output streams instead. Thanks!
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Jul 21, 2021
* add error handling to dashboard index pattern observable to prevent issues when embeddables do not load
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Jul 21, 2021
* add error handling to dashboard index pattern observable to prevent issues when embeddables do not load
ThomThomson
added a commit
that referenced
this pull request
Jul 21, 2021
ThomThomson
added a commit
that referenced
this pull request
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #105963
Adds basic error handling to the dashboard index pattern sync observable. When an error is pushed to the output of any embeddable in the container, a
catchErroroperator catches and swallows the error. This allows error embeddables to properly catch and show their own errors, while always showing the correct index pattern(s) on the dashboard, with any mix of error & non-error embeddable panels.This PR also adds a new dashboard error case JSON file for use with
kbn_archiver, as well as a usage example. Eventually the rest of thees_archiverdata used for the dashboard functional tests will need to be migrated over.Checklist
Delete any items that are not applicable to this PR.
For maintainers