[Pie, XY] Filter button in legend keyword accessible #106374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
added
Feature:Pie Chart
stratoula
changed the title
stratoula
changed the title
stratoula
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
Hey @stratoula, the improvement works fine, but in both cases (legacy and lens) the legend loses focus completely when closing the popover and this is not accessible approach. The problem is probably hidden in the elastic-charts implementation because I can reproduce it in the storybook. I'll submit the issue in elastic-charts. Jul-26-2021.13-34-35.mp4elastic-charts.mp4 |
mbondyra
approved these changes
Jul 26, 2021
|
Great finding Marta, thank you a lot! |
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Jul 26, 2021
…ic#106374) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
stratoula
added a commit
that referenced
this pull request
Jul 26, 2021
…) (#106707) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
streamich
pushed a commit
to vadimkibana/kibana
that referenced
this pull request
Aug 8, 2021
…ic#106374) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #106360
It makes the legend action button keyword accessible. It works correctly in Lens, the visualizations that actually have this problem is the pie and xy charts (legacy new implementations)
Checklist