[Vega, TSVB, Timeline] fix send data request twice when opening visualizations. #106398

alexwizp · 2021-07-21T12:16:12Z

Closes: #106228

Summary

This PR fixes the Vega, TSVB, Timeline send data request twice when opening visualizations. #106228

Screens

`TSVB`

`Timelion`

`Vega`

…lizations. Closes: elastic#106398

VladLasitsa

LGTM, tested locally

elasticmachine · 2021-07-23T14:15:11Z

Pinging @elastic/kibana-app (Team:KibanaApp)

alexwizp · 2021-07-26T06:58:44Z

@elasticmachine merge upstream

stratoula

It seems fine to me Alex! It is a great performance enhancement.
I couldn't find any regressions but lets not backport it in 7.14

kibanamachine · 2021-07-26T09:15:12Z

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`actions`	-	117	+117
`advancedSettings`	-	22	+22
`alerting`	-	234	+234
`apm`	-	39	+39
`apmOss`	-	4	+4
`banners`	-	9	+9
`bfetch`	-	62	+62
`canvas`	-	5	+5
`cases`	-	407	+407
`charts`	-	159	+159
`cloud`	-	21	+21
`core`	-	1080	+1080
`dashboard`	-	137	+137
`dashboardEnhanced`	-	50	+50
`dashboardMode`	-	11	+11
`data`	-	3162	+3162
`dataEnhanced`	-	16	+16
`dataVisualizer`	-	104	+104
`devTools`	-	8	+8
`discover`	-	55	+55
`discoverEnhanced`	-	37	+37
`embeddable`	-	384	+384
`embeddableEnhanced`	-	14	+14
`encryptedSavedObjects`	-	28	+28
`enterpriseSearch`	-	2	+2
`esUiShared`	-	90	+90
`eventLog`	-	70	+70
`expressionError`	-	12	+12
`expressionRepeatImage`	-	28	+28
`expressionRevealImage`	-	4	+4
`expressions`	-	1567	+1567
`expressionShape`	-	90	+90
`features`	-	97	+97
`fileUpload`	-	128	+128
`fleet`	-	1033	+1033
`globalSearch`	-	14	+14
`home`	-	70	+70
`indexLifecycleManagement`	-	4	+4
`indexManagement`	-	157	+157
`indexPatternFieldEditor`	-	29	+29
`infra`	-	22	+22
`inspector`	-	78	+78
`kibanaLegacy`	-	62	+62
`kibanaReact`	-	230	+230
`kibanaUtils`	-	359	+359
`lens`	-	169	+169
`licenseApiGuard`	-	8	+8
`licenseManagement`	-	3	+3
`licensing`	-	42	+42
`lists`	-	143	+143
`management`	-	40	+40
`maps`	-	203	+203
`mapsEms`	-	75	+75
`metricsEntities`	-	6	+6
`ml`	-	274	+274
`monitoring`	-	10	+10
`navigation`	-	31	+31
`newsfeed`	-	17	+17
`observability`	-	219	+219
`osquery`	-	11	+11
`presentationUtil`	-	136	+136
`remoteClusters`	-	4	+4
`reporting`	-	132	+132
`rollup`	-	20	+20
`ruleRegistry`	-	60	+60
`runtimeFields`	-	19	+19
`savedObjects`	-	199	+199
`savedObjectsManagement`	-	85	+85
`savedObjectsTagging`	-	50	+50
`savedObjectsTaggingOss`	-	50	+50
`screenshotMode`	-	17	+17
`security`	-	51	+51
`securityOss`	-	9	+9
`securitySolution`	-	1245	+1245
`share`	-	83	+83
`snapshotRestore`	-	22	+22
`spacesOss`	-	5	+5
`stackAlerts`	-	4	+4
`taskManager`	-	25	+25
`telemetryCollectionManager`	-	29	+29
`telemetryCollectionXpack`	-	1	+1
`telemetryManagementSection`	-	13	+13
`timelines`	-	763	+763
`triggersActionsUi`	-	228	+228
`uiActions`	-	88	+88
`uiActionsEnhanced`	-	147	+147
`urlForwarding`	-	15	+15
`usageCollection`	-	16	+16
`visTypeTimeseries`	-	10	+10
`visualizations`	-	229	+229
total			+15317

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id	before	after	diff
`bfetch`	-	1	+1
`charts`	-	2	+2
`core`	-	148	+148
`dashboard`	-	1	+1
`data`	-	98	+98
`dataVisualizer`	-	3	+3
`embeddable`	-	4	+4
`esUiShared`	-	4	+4
`expressions`	-	58	+58
`fileUpload`	-	4	+4
`fleet`	-	15	+15
`indexManagement`	-	12	+12
`indexPatternFieldEditor`	-	1	+1
`inspector`	-	6	+6
`kibanaLegacy`	-	3	+3
`kibanaReact`	-	5	+5
`kibanaUtils`	-	3	+3
`maps`	-	2	+2
`mapsEms`	-	1	+1
`ml`	-	10	+10
`presentationUtil`	-	3	+3
`reporting`	-	1	+1
`savedObjects`	-	3	+3
`savedObjectsTaggingOss`	-	3	+3
`securitySolution`	-	8	+8
`share`	-	1	+1
`snapshotRestore`	-	1	+1
`timelines`	-	6	+6
`triggersActionsUi`	-	1	+1
`uiActionsEnhanced`	-	2	+2
`visTypeTimeseries`	-	1	+1
`visualizations`	-	13	+13
total			+424

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`visualizations`	101.4KB	101.5KB	+71.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`actions`	-	7	+7
`advancedSettings`	-	1	+1
`alerting`	-	16	+16
`apm`	-	30	+30
`bfetch`	-	2	+2
`canvas`	-	3	+3
`cases`	-	14	+14
`charts`	-	1	+1
`core`	-	31	+31
`dashboard`	-	9	+9
`data`	-	64	+64
`dataEnhanced`	-	2	+2
`devTools`	-	2	+2
`discover`	-	6	+6
`discoverEnhanced`	-	2	+2
`embeddable`	-	3	+3
`encryptedSavedObjects`	-	3	+3
`esUiShared`	-	1	+1
`eventLog`	-	4	+4
`expressionError`	-	2	+2
`expressionRevealImage`	-	1	+1
`expressions`	-	5	+5
`features`	-	2	+2
`fileUpload`	-	1	+1
`fleet`	-	8	+8
`globalSearch`	-	5	+5
`home`	-	5	+5
`indexManagement`	-	3	+3
`indexPatternFieldEditor`	-	4	+4
`infra`	-	3	+3
`inspector`	-	4	+4
`kibanaLegacy`	-	1	+1
`kibanaReact`	-	4	+4
`kibanaUtils`	-	8	+8
`lens`	-	14	+14
`licensing`	-	8	+8
`lists`	-	38	+38
`management`	-	5	+5
`maps`	-	11	+11
`metricsEntities`	-	1	+1
`ml`	-	33	+33
`monitoring`	-	2	+2
`navigation`	-	2	+2
`observability`	-	10	+10
`presentationUtil`	-	5	+5
`reporting`	-	14	+14
`ruleRegistry`	-	9	+9
`runtimeFields`	-	2	+2
`savedObjects`	-	5	+5
`screenshotMode`	-	1	+1
`security`	-	6	+6
`securityOss`	-	3	+3
`securitySolution`	-	28	+28
`share`	-	8	+8
`snapshotRestore`	-	1	+1
`taskManager`	-	8	+8
`telemetryCollectionManager`	-	4	+4
`timelines`	-	25	+25
`triggersActionsUi`	-	19	+19
`uiActions`	-	11	+11
`uiActionsEnhanced`	-	10	+10
`usageCollection`	-	2	+2
`visTypeTimeseries`	-	3	+3
`visualizations`	-	12	+12
total			+557

Unknown metric groups

API count

id	before	after	diff
`actions`	-	117	+117
`advancedSettings`	-	23	+23
`alerting`	-	242	+242
`apm`	-	39	+39
`apmOss`	-	4	+4
`banners`	-	9	+9
`bfetch`	-	73	+73
`canvas`	-	6	+6
`cases`	-	445	+445
`charts`	-	190	+190
`cloud`	-	21	+21
`core`	-	2359	+2359
`dashboard`	-	160	+160
`dashboardEnhanced`	-	51	+51
`dashboardMode`	-	11	+11
`data`	-	3716	+3716
`dataEnhanced`	-	16	+16
`dataVisualizer`	-	104	+104
`devTools`	-	10	+10
`discover`	-	81	+81
`discoverEnhanced`	-	39	+39
`embeddable`	-	456	+456
`embeddableEnhanced`	-	14	+14
`encryptedSavedObjects`	-	30	+30
`enterpriseSearch`	-	2	+2
`esUiShared`	-	92	+92
`eventLog`	-	70	+70
`expressionError`	-	12	+12
`expressionRepeatImage`	-	28	+28
`expressionRevealImage`	-	4	+4
`expressions`	-	2003	+2003
`expressionShape`	-	90	+90
`features`	-	215	+215
`fileUpload`	-	128	+128
`fleet`	-	1128	+1128
`globalSearch`	-	68	+68
`home`	-	94	+94
`indexLifecycleManagement`	-	4	+4
`indexManagement`	-	162	+162
`indexPatternFieldEditor`	-	31	+31
`infra`	-	25	+25
`inspector`	-	101	+101
`kibanaLegacy`	-	66	+66
`kibanaReact`	-	260	+260
`kibanaUtils`	-	551	+551
`lens`	-	185	+185
`licenseApiGuard`	-	8	+8
`licenseManagement`	-	3	+3
`licensing`	-	117	+117
`lists`	-	150	+150
`management`	-	40	+40
`maps`	-	204	+204
`mapsEms`	-	75	+75
`metricsEntities`	-	9	+9
`ml`	-	278	+278
`monitoring`	-	10	+10
`navigation`	-	31	+31
`newsfeed`	-	17	+17
`observability`	-	219	+219
`osquery`	-	11	+11
`presentationUtil`	-	163	+163
`remoteClusters`	-	4	+4
`reporting`	-	133	+133
`rollup`	-	20	+20
`ruleRegistry`	-	60	+60
`runtimeFields`	-	24	+24
`savedObjects`	-	213	+213
`savedObjectsManagement`	-	96	+96
`savedObjectsTagging`	-	54	+54
`savedObjectsTaggingOss`	-	89	+89
`screenshotMode`	-	22	+22
`security`	-	112	+112
`securityOss`	-	12	+12
`securitySolution`	-	1296	+1296
`share`	-	123	+123
`snapshotRestore`	-	23	+23
`spaces`	-	106	+106
`spacesOss`	-	72	+72
`stackAlerts`	-	4	+4
`taskManager`	-	52	+52
`telemetry`	-	42	+42
`telemetryCollectionManager`	-	29	+29
`telemetryCollectionXpack`	-	1	+1
`telemetryManagementSection`	-	14	+14
`timelines`	-	882	+882
`triggersActionsUi`	-	237	+237
`uiActions`	-	127	+127
`uiActionsEnhanced`	-	205	+205
`urlForwarding`	-	15	+15
`usageCollection`	-	57	+57
`visTypeTimeseries`	-	10	+10
`visualizations`	-	247	+247
total			+19251

References to deprecated APIs

id	before	after	diff
`actions`	-	8	+8
`alerting`	-	32	+32
`apm`	-	7	+7
`canvas`	-	53	+53
`cases`	-	151	+151
`crossClusterReplication`	-	2	+2
`dashboard`	-	128	+128
`dashboardEnhanced`	-	10	+10
`dataEnhanced`	-	53	+53
`dataVisualizer`	-	16	+16
`discover`	-	102	+102
`discoverEnhanced`	-	19	+19
`embeddable`	-	2	+2
`encryptedSavedObjects`	-	2	+2
`fleet`	-	89	+89
`globalSearch`	-	4	+4
`graph`	-	2	+2
`indexLifecycleManagement`	-	2	+2
`indexManagement`	-	12	+12
`infra`	-	292	+292
`lens`	-	168	+168
`lists`	-	103	+103
`maps`	-	592	+592
`ml`	-	140	+140
`observability`	-	34	+34
`presentationUtil`	-	2	+2
`savedObjects`	-	6	+6
`savedObjectsManagement`	-	18	+18
`savedObjectsTaggingOss`	-	5	+5
`security`	-	2	+2
`securitySolution`	-	881	+881
`stackAlerts`	-	104	+104
`timelines`	-	76	+76
`transform`	-	16	+16
`uptime`	-	11	+11
`urlDrilldown`	-	18	+18
`visTypeTimeseries`	-	10	+10
`visualizations`	-	32	+32
total			+3204

History

💚 Build #140553 succeeded e4baf62
💚 Build #140420 succeeded 383d6c4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

…lizations. (elastic#106398) Closes: elastic#106398 Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…lizations. (#106398) (#106687) Closes: #106398 Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…lizations. (elastic#106398) Closes: elastic#106398 Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

alexwizp requested a review from VladLasitsa July 21, 2021 12:16

alexwizp changed the title ~~[Vega, TSVB, Timeline] fix send data request twice when opening visua…~~ [Vega, TSVB, Timeline] fix send data request twice when opening visualizations. Jul 21, 2021

alexwizp force-pushed the 106228 branch from 4da6003 to f837bd1 Compare July 21, 2021 13:39

alexwizp added a commit to alexwizp/kibana that referenced this pull request Jul 22, 2021

[Vega, TSVB, Timeline] fix send data request twice when opening visua…

a7c517b

…lizations. Closes: elastic#106398

alexwizp force-pushed the 106228 branch from f837bd1 to a7c517b Compare July 22, 2021 11:54

alexwizp requested a review from stratoula July 22, 2021 12:01

alexwizp self-assigned this Jul 22, 2021

alexwizp added v7.15.0 v8.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:fix Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Jul 22, 2021

elastic deleted a comment from kibanamachine Jul 22, 2021

alexwizp added a commit to alexwizp/kibana that referenced this pull request Jul 22, 2021

[Vega, TSVB, Timeline] fix send data request twice when opening visua…

383d6c4

…lizations. Closes: elastic#106398

alexwizp force-pushed the 106228 branch from a7c517b to 383d6c4 Compare July 22, 2021 15:39

elastic deleted a comment from kibanamachine Jul 22, 2021

[Vega, TSVB, Timeline] fix send data request twice when opening visua…

e4baf62

…lizations. Closes: elastic#106398

alexwizp force-pushed the 106228 branch from 383d6c4 to e4baf62 Compare July 23, 2021 10:51

VladLasitsa approved these changes Jul 23, 2021

View reviewed changes

alexwizp marked this pull request as ready for review July 23, 2021 14:15

alexwizp requested a review from a team July 23, 2021 14:15

Merge branch 'master' into 106228

39b3f33

stratoula approved these changes Jul 26, 2021

View reviewed changes

stratoula added this to In progress in Legacy visualizations via automation Jul 26, 2021

alexwizp merged commit 7c064ec into elastic:master Jul 26, 2021

Legacy visualizations automation moved this from In progress to Done Jul 26, 2021

alexwizp mentioned this pull request Jul 26, 2021

[7.x] [Vega, TSVB, Timeline] fix send data request twice when opening visualizations. (#106398) #106687

Merged

alexwizp mentioned this pull request Jul 26, 2021

[Dashboard] /api/metrics/vis/data calls are duplicated #96629

Closed

rayafratkina added the performance label Aug 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Vega, TSVB, Timeline] fix send data request twice when opening visualizations. #106398

[Vega, TSVB, Timeline] fix send data request twice when opening visualizations. #106398

alexwizp commented Jul 21, 2021 •

edited

VladLasitsa left a comment

elasticmachine commented Jul 23, 2021

alexwizp commented Jul 26, 2021

stratoula left a comment

kibanamachine commented Jul 26, 2021

API count

References to deprecated APIs

[Vega, TSVB, Timeline] fix send data request twice when opening visualizations. #106398

[Vega, TSVB, Timeline] fix send data request twice when opening visualizations. #106398

Conversation

alexwizp commented Jul 21, 2021 • edited

Summary

Screens

TSVB

Timelion

Vega

VladLasitsa left a comment

Choose a reason for hiding this comment

elasticmachine commented Jul 23, 2021

alexwizp commented Jul 26, 2021

stratoula left a comment

Choose a reason for hiding this comment

kibanamachine commented Jul 26, 2021

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Any counts in public APIs

Async chunks

Public APIs missing exports

API count

References to deprecated APIs

History

alexwizp commented Jul 21, 2021 •

edited

`TSVB`

`Timelion`

`Vega`