[ML] Data frame analytics: ensure results view loads correctly for job created in dev tools #107024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
release_note:fix
:ml
Feature:Data Frame Analytics
|
Pinging @elastic/ml-ui (:ml) |
qn895
approved these changes
Jul 28, 2021
|
LGTM 🎉 |
walterra
reviewed
Jul 29, 2021
There was a problem hiding this comment.
Looking at the docs here (https://www.elastic.co/guide/en/elasticsearch/reference/current/put-dfanalytics.html) it looks like analyzed_fields is meant to be optional in general. Suggest to updated the interface DataFrameAnalyticsConfig so it's optional there too. Then TS should catch the original code without the ?.
alvarezmelissa87
force-pushed
the
ml-dfa-fix-results-view
branch
from
0592c6b
to
0f1af08
Compare
|
Updated and ready for a final look when you get a chance 🙏 cc @walterra |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Jul 30, 2021
…b created in dev tools (elastic#107024) * check analyzed_fields exists * update DataFrameAnalyticsConfig type to make analyzed_fields optional * updating accessing analyzed_fields for type update
streamich
pushed a commit
to vadimkibana/kibana
that referenced
this pull request
Aug 8, 2021
…b created in dev tools (elastic#107024) * check analyzed_fields exists * update DataFrameAnalyticsConfig type to make analyzed_fields optional * updating accessing analyzed_fields for type update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #106275
Checks that
analytized_fieldsexists before trying to accessincludesorexcludes. Extends fix to outlier detection results page.Before:
After:
Checklist
Delete any items that are not applicable to this PR.