Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability RAC] Leave the severity of the alerts empty if it's unknown #107029

Merged
merged 4 commits into from
Aug 9, 2021
Merged

[Observability RAC] Leave the severity of the alerts empty if it's unknown #107029

merged 4 commits into from
Aug 9, 2021

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented Jul 28, 2021

Summary

Closes #105228.

Before

Screenshot 2021-07-28 at 17 10 00

After

Screenshot 2021-07-28 at 16 48 01

@afgomez afgomez added v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated: Automatically backport this PR after it's merged v7.15.0 Feature:Observability RAC labels Jul 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@afgomez afgomez requested a review from a team July 29, 2021 08:27
@mgiota mgiota self-requested a review July 30, 2021 06:06
@mgiota
Copy link
Contributor

mgiota commented Jul 30, 2021 •
edited
Loading

@afgomez Looks like acceptance criteria were not uptodate. From the ongoing discussions on the issue #105228 looks like we want to display warning if it is a warning and default toalert | critical | empty in any other case.
@cyrille-leclerc suggested alert and @weltenwort suggested critical or empty.

My suggestion for the acceptance criteria for this ticket is:

  • diplay warning if it is a warning
  • default to critical in any other case to be consistent with other Kibana apps.

mgiota
mgiota requested changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@mgiota mgiota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look at my comment above

@mgiota mgiota self-requested a review August 2, 2021 11:41
mgiota
mgiota approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@mgiota mgiota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this PR as @cyrille-leclerc approved the empty value in case we have no severity

@afgomez
Copy link
Contributor Author

afgomez commented Aug 9, 2021

@elasticmachine merge upstream

@afgomez afgomez enabled auto-merge (squash) August 9, 2021 14:51
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 511.2KB 511.0KB -200.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afgomez afgomez merged commit 3eac913 into elastic:master Aug 9, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 107029

@afgomez afgomez mentioned this pull request Aug 10, 2021
Merged
afgomez pushed a commit to afgomez/kibana that referenced this pull request Aug 10, 2021
[Observability RAC] Leave the severity of the alerts empty if it's un…
055d63d 
…known (elastic#107029)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
@afgomez afgomez deleted the 105228-alerts-default-to-blank branch August 10, 2021 09:04
afgomez pushed a commit that referenced this pull request Aug 10, 2021
[Observability RAC] Leave the severity of the alerts empty if it's un…
9731876 
…known (#107029) (#108014)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
@mgiota mgiota mentioned this pull request Aug 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyrille-leclerc cyrille-leclerc cyrille-leclerc approved these changes

@mgiota mgiota mgiota approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged Feature:Observability RAC release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Observability RAC] Avoid unknown alerts table severity values
5 participants
@afgomez @elasticmachine @mgiota @kibanamachine @cyrille-leclerc