[SolutionNav] Fixed tabindex and collapsible functionality
#107462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myasonik
approved these changes
Aug 2, 2021
src/plugins/kibana_react/public/page_template/solution_nav/solution_nav.tsx
Outdated
Show resolved
Hide resolved
ryankeairns
approved these changes
Aug 2, 2021
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
cchaos
added
auto-backport
cchaos
added a commit
to cchaos/kibana
that referenced
this pull request
Aug 9, 2021
…#107462) * Fixed `tabIndex` * Added embellishment back in * Fixed the collapse button visibility and usability
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 9, 2021
…#107462) * Fixed `tabIndex` * Added embellishment back in * Fixed the collapse button visibility and usability
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
cchaos
added a commit
that referenced
this pull request
Aug 9, 2021
#107943) * Fixed `tabIndex` * Added embellishment back in * Fixed the collapse button visibility and usability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
tabindexThe Solution Nav component was setting
tabindex=-1manually on every side nav item passed in when the side nav was set to hidden because of the collapsibility. Unfortunately, it was not removing this when the side nav was made visible again, degrading the keyboard accessibility from then on.I've changed that function to accept the
isHiddenprop instead and then set thetabindexbased on that prop.Increased usability of the collapsible button
Gave the button a background color when in expanded mode.
Before, the button could potentially overlap the scrollbar making it hard to distinguish. I simply changed this to have a white (empty shade) background so that it stays visible with still being subtle.
And added the embellishment back in 😉
Made the collapsed version of the button expand the entire collapsed area
Before, the target area of the expand button was only
24x24pxwhich is really small especially on medium sized screens when this is the only way to trigger the solution nav. I have instead grown the button to expand the entire area creating a large hit area for expansion. (And also decreased the width to give more space back to the content).Checklist
Delete any items that are not applicable to this PR.