Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Disable query delay editing for non-admin users #107517

Merged
merged 1 commit into from Aug 3, 2021
Merged

[ML] Disable query delay editing for non-admin users #107517

merged 1 commit into from Aug 3, 2021

Conversation

jgowdyelastic
Copy link
Member

The query delay editing link should be disabled if the user does not have permission to edit the datafeed.
Also updates the tooltip text to cover both reasons why the link might be disabled.

image

@jgowdyelastic jgowdyelastic self-assigned this Aug 3, 2021
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner August 3, 2021 12:23
@jgowdyelastic jgowdyelastic added :ml auto-backport Deprecated: Automatically backport this PR after it's merged Feature:Anomaly Detection ML anomaly detection non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.15.0 v8.0.0 labels Aug 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience release_note:fix and removed non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes labels Aug 3, 2021
alvarezmelissa87
alvarezmelissa87 approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.9MB 5.9MB +239.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@qn895
Copy link
Member

qn895 commented Aug 3, 2021

Tested and LGTM 🎉

@jgowdyelastic jgowdyelastic merged commit 1fbb34a into elastic:master Aug 3, 2021
@jgowdyelastic jgowdyelastic deleted the disable-query-delay-editing-for-non-admin-users branch August 3, 2021 19:40
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 3, 2021
@jgowdyelastic @kibanamachine
[ML] Disable query delay editing for non-admin users (elastic#107517)
481f53c
@kibanamachine kibanamachine mentioned this pull request Aug 3, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 3, 2021
@kibanamachine @jgowdyelastic
[ML] Disable query delay editing for non-admin users (#107517) (#107582)
8758ff7 
Co-authored-by: James Gowdy <jgowdy@elastic.co>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@jgowdyelastic @vadimkibana
[ML] Disable query delay editing for non-admin users (elastic#107517)
44564e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@qn895 qn895 qn895 approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
auto-backport Deprecated: Automatically backport this PR after it's merged bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml release_note:fix review v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jgowdyelastic @elasticmachine @kibanamachine @qn895 @alvarezmelissa87