Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maps] add indication in layer TOC when layer is filtered by map bounds #107662

Merged
merged 6 commits into from Aug 11, 2021

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Aug 4, 2021

Fixes #104154

Screen Shot 2021-08-04 at 10 33 00 AM

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese
Copy link
Contributor Author

nreese commented Aug 9, 2021

@elasticmachine merge upstream

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we're losing that little row of icons.

master:
image

vs

PR:
image

Is it possible to add this to the icon row in the layerTOC? It would make legibility so much easier.

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Aug 10, 2021

In hindsight, it has something to do with the styling

image

Icons are outlined in white iso grey.

@nreese
Copy link
Contributor Author

nreese commented Aug 11, 2021

@elasticmachine merge upstream

@kibanamachine kibanamachine requested a review from a team as a code owner August 11, 2021 14:14
@nreese nreese added the auto-backport Deprecated: Automatically backport this PR after it's merged label Aug 11, 2021
@nreese
Copy link
Contributor Author

nreese commented Aug 11, 2021

Icons are outlined in white iso grey.

I have reverted the color change from subdued to ghost. Its not needed for this PR and was causing the problems you were seeing

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 3.2MB 3.2MB +449.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@nreese nreese merged commit 2ce8086 into elastic:master Aug 11, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 11, 2021
…ds (elastic#107662)

* [maps] add indication in layer TOC when layer is filtered by map bounds

* fix i18n id collision

* use ghost color so icons are more visible

* revert icon color change

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 11, 2021
…ds (#107662) (#108270)

* [maps] add indication in layer TOC when layer is filtered by map bounds

* fix i18n id collision

* use ghost color so icons are more visible

* revert icon color change

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:enhancement v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maps] "no results found" is misleading
4 participants