Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics UI] Remove alert previews #107978

Merged

Conversation

simianhacker
Copy link
Member

Summary

This PR closed #107946 by removing the alert preview functionality from the Metrics Threshold Alert and the Inventory Threshold Alert.

@simianhacker simianhacker added release_note:fix Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.15.0 labels Aug 9, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 953 950 -3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.7MB 1.7MB -48.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 150.5KB 149.2KB -1.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@simianhacker simianhacker marked this pull request as ready for review August 11, 2021 17:30
@simianhacker simianhacker requested a review from a team as a code owner August 11, 2021 17:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@simianhacker simianhacker added the auto-backport Deprecated: Automatically backport this PR after it's merged label Aug 12, 2021
@simianhacker simianhacker merged commit 9045f73 into elastic:master Aug 12, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 12, 2021
* [Metrics UI] Remove alert previews

* Fixing i18n strings

* Adding back in isTooManyBucketsPreviewException for evaluate_alert

* Fixing import

* Removing more obsolete code

* removing unused strings for i18n

* removing unused range function
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 12, 2021
* [Metrics UI] Remove alert previews

* Fixing i18n strings

* Adding back in isTooManyBucketsPreviewException for evaluate_alert

* Fixing import

* Removing more obsolete code

* removing unused strings for i18n

* removing unused range function

Co-authored-by: Chris Cowan <chris@chriscowan.us>
@simianhacker simianhacker deleted the issue-107946-remove-alert-previews branch April 17, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged Feature:Metrics UI Metrics UI feature release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metrics UI] Remove preview functionality from Alerts (Inventory and Metric Threshold)
4 participants