New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Replace APM error rate table with failed transactions correlations #108441
Merged
qn895
merged 26 commits into
elastic:master
from
qn895:ml-apm-failure-correlation-in-flyout
Aug 17, 2021
Merged
Changes from 20 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
63a10b8
[ML] Refactor with new table
qn895 0633e88
[ML] Fix types, rename var
qn895 43d7a85
[ML] Remove duplicate action columns
qn895 1ce425c
[ML] Finish renaming for consistency
qn895 cb61232
[ML] Add failure correlations help popover
qn895 1ca029d
[ML] Add failure correlations help popover
qn895 56e21dd
Merge upstream/main into branch
qn895 b25e6b6
[ML] Extend correlation help
lcawl b52b3e0
Merge branch 'ml-apm-failure-correlation-in-flyout' of https://github…
qn895 5e9d247
Update message
qn895 e70878c
[ML] Delete old legacy correlations pages
qn895 1554436
[ML] Address comments, rename
qn895 19b430f
Merge remote-tracking branch 'upstream/master' into ml-apm-failure-co…
qn895 5ceed16
[ML] Revert deletion of latency_correlations.tsx
qn895 c6940c1
[ML] Add unit test for getFailedTransactionsCorrelationImpactLabel
qn895 f4ecc66
[ML] Rename & fix types
qn895 b780c79
[ML] Fix logic to note include 0.02 threshold
qn895 014b5cd
Merge branch 'master' into ml-apm-failure-correlation-in-flyout
kibanamachine 6bbb68c
[ML] Refactor to use state handler
qn895 ad490d2
Merge remote-tracking branch 'upstream/master' into ml-apm-failure-co…
qn895 bcec466
[ML] Fix hardcoded index, columns, popover
qn895 fb6bb05
Merge upstream/master into branch
qn895 caf5c29
[ML] Replace failed transaction tab
qn895 1af8288
[ML] Fix unused translations
qn895 d709dc1
[ML] Delete empty files
qn895 557a520
[ML] Move beta badge to be inside tab content
qn895 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
32 changes: 32 additions & 0 deletions
32
x-pack/plugins/apm/common/search_strategies/failure_correlations/constants.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { i18n } from '@kbn/i18n'; | ||
|
||
export const FAILED_TRANSACTIONS_CORRELATION_SEARCH_STRATEGY = | ||
'apmFailedTransactionsCorrelationsSearchStrategy'; | ||
|
||
export const FAILED_TRANSACTIONS_IMPACT_THRESHOLD = { | ||
HIGH: i18n.translate( | ||
'xpack.apm.correlations.failedTransactions.highImpactText', | ||
{ | ||
defaultMessage: 'High', | ||
} | ||
), | ||
MEDIUM: i18n.translate( | ||
'xpack.apm.correlations.failedTransactions.mediumImpactText', | ||
{ | ||
defaultMessage: 'Medium', | ||
} | ||
), | ||
LOW: i18n.translate( | ||
'xpack.apm.correlations.failedTransactions.lowImpactText', | ||
{ | ||
defaultMessage: 'Low', | ||
} | ||
), | ||
} as const; |
25 changes: 25 additions & 0 deletions
25
x-pack/plugins/apm/common/search_strategies/failure_correlations/types.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { FAILED_TRANSACTIONS_IMPACT_THRESHOLD } from './constants'; | ||
|
||
export interface FailedTransactionsCorrelationValue { | ||
key: string; | ||
doc_count: number; | ||
bg_count: number; | ||
score: number; | ||
pValue: number | null; | ||
fieldName: string; | ||
fieldValue: string; | ||
} | ||
|
||
export type FailureCorrelationImpactThreshold = typeof FAILED_TRANSACTIONS_IMPACT_THRESHOLD[keyof typeof FAILED_TRANSACTIONS_IMPACT_THRESHOLD]; | ||
|
||
export interface CorrelationsTerm { | ||
fieldName: string; | ||
fieldValue: string; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
columns
is already a required prop with this type do we need this assignment or the?? []
at all?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated here bcec466