Abort full screen in dashboard and maps when user clicks back button #108747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
changed the title
|
@elasticmachine merge upstream |
ThomThomson
approved these changes
Aug 16, 2021
|
@elasticmachine merge upstream |
thomasneirynck
approved these changes
Aug 18, 2021
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
Unknown metric groupsAPI count
API count missing comments
History
To update your PR or re-run it, just comment with: |
nreese
added
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 18, 2021
…lastic#108747) * [Maps] reverse geocoding tutorial * reverse geocoding step * add final step * use dash delemiter instead of underscore in file name * add float to step 3 so its on the same page * add into to step 3 * Abort full screen in dashboard and maps when user clicks back button * remove doc changes from another PR * remove change in file heading * tslint and fix unit test * eslint Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Aug 18, 2021
…lastic#108747) * [Maps] reverse geocoding tutorial * reverse geocoding step * add final step * use dash delemiter instead of underscore in file name * add float to step 3 so its on the same page * add into to step 3 * Abort full screen in dashboard and maps when user clicks back button * remove doc changes from another PR * remove change in file heading * tslint and fix unit test * eslint Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
|
7.15 backport #109143 |
kibanamachine
added a commit
that referenced
this pull request
Aug 18, 2021
…108747) (#109140) * [Maps] reverse geocoding tutorial * reverse geocoding step * add final step * use dash delemiter instead of underscore in file name * add float to step 3 so its on the same page * add into to step 3 * Abort full screen in dashboard and maps when user clicks back button * remove doc changes from another PR * remove change in file heading * tslint and fix unit test * eslint Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
nreese
added a commit
that referenced
this pull request
Aug 18, 2021
…108747) (#109143) * [Maps] reverse geocoding tutorial * reverse geocoding step * add final step * use dash delemiter instead of underscore in file name * add float to step 3 so its on the same page * add into to step 3 * Abort full screen in dashboard and maps when user clicks back button * remove doc changes from another PR * remove change in file heading * tslint and fix unit test * eslint Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
KOTungseth
added
the
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108609.
There is a bug in
ExitFullScreenButtonwherechrome.setIsVisibleis not called on unmount.This PR fixes the bug by moving
chrome.setIsVisibleinteractions intoExitFullScreenButton. That way,ExitFullScreenButtoncan properly hide/show chrome when mounted and unmounted.