Convert default to named exports - errors #10986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stacey-gammon
force-pushed
the
default-to-named-errors
branch
from
6b87d15
to
829399c
Compare
kimjoar
reviewed
Mar 31, 2017
src/ui/public/errors.js
Outdated
| KbnError.call(this, | ||
| 'Courier attempted to start a query before the previous had finished.', | ||
| errors.HastyRefresh); | ||
| }; | ||
| _.class(errors.HastyRefresh).inherits(KbnError); |
There was a problem hiding this comment.
Not really relevant to this PR, but as we're changing this code I'll ask:
Any reason we can't have class KbnError extends Errors and class HastyRefresh extends KbnError? If that works it would clean up this code even more.
There was a problem hiding this comment.
No reason I can see. Changed them all and added tests for a sanity check. Indeed looks much better this way.
kimjoar
approved these changes
Mar 31, 2017
|
Jenkins failed due to #10980 jenkins, test this |
|
jenkins, test this |
|
Failed on a different test, but same function (trying to open a link from the dashboard landing page): Going to try merging #11004 |
|
jenkins, test this (build aborted) |
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Apr 4, 2017
* Convert default to named exports - errors * Make all error classes use class syntax and extends add tests * Extending Error apparently doesn't work * Merge PR elastic#11004 to try to fix test failures
stacey-gammon
added a commit
that referenced
this pull request
Apr 4, 2017
simianhacker
pushed a commit
to simianhacker/kibana
that referenced
this pull request
Apr 5, 2017
* Convert default to named exports - errors * Make all error classes use class syntax and extends add tests * Extending Error apparently doesn't work * Merge PR elastic#11004 to try to fix test failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #10981, but am doing some conversions separately since it will be a large chunk of work. Plus this file wasn't a straight conversion as I got rid of the external errors object and am exporting each error individually.
Background: #8641