-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Fix for no-data state for fallback from aggregated transactions #109995
[APM] Fix for no-data state for fallback from aggregated transactions #109995
Conversation
Pinging @elastic/apm-ui (Team:apm) |
x-pack/plugins/apm/server/lib/helpers/aggregated_transactions/get_fallback_to_transactions.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/server/lib/helpers/aggregated_transactions/get_fallback_to_transactions.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/server/lib/helpers/aggregated_transactions/get_fallback_to_transactions.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/server/lib/helpers/aggregated_transactions/get_fallback_to_transactions.ts
Outdated
Show resolved
Hide resolved
bool: { | ||
filter: [ | ||
{ exists: { field: TRANSACTION_DURATION } }, | ||
...(start && end ? rangeQuery(start, end) : []), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should start
and end
be required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The optional date range is consistent with getSearchAggregatedTransactions
https://github.com/elastic/kibana/blob/master/x-pack/plugins/apm/server/lib/helpers/aggregated_transactions/index.ts#L40
x-pack/plugins/apm/server/lib/helpers/aggregated_transactions/get_fallback_to_transactions.ts
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
…elastic#109995) * [APM] Fix for no-data state for fallback from aggregated transactions (elastic#109609) * PR feedback and unit tests * fixes lint error Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…elastic#109995) * [APM] Fix for no-data state for fallback from aggregated transactions (elastic#109609) * PR feedback and unit tests * fixes lint error Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…#109995) (#110624) * [APM] Fix for no-data state for fallback from aggregated transactions (#109609) * PR feedback and unit tests * fixes lint error Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…#109995) (#110625) * [APM] Fix for no-data state for fallback from aggregated transactions (#109609) * PR feedback and unit tests * fixes lint error Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Fixes #109609.