Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Fix for no-data state for fallback from aggregated transactions #109995

Conversation

ogupte
Copy link
Contributor

@ogupte ogupte commented Aug 25, 2021

Fixes #109609.

@ogupte ogupte added release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v7.16.0 labels Aug 25, 2021
@ogupte ogupte requested a review from a team as a code owner August 25, 2021 06:27
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Aug 25, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

bool: {
filter: [
{ exists: { field: TRANSACTION_DURATION } },
...(start && end ? rangeQuery(start, end) : []),
Copy link
Member

@sorenlouv sorenlouv Aug 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should start and end be required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ogupte
Copy link
Contributor Author

ogupte commented Aug 30, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ogupte ogupte merged commit e22c46b into elastic:master Aug 31, 2021
ogupte added a commit to ogupte/kibana that referenced this pull request Aug 31, 2021
…elastic#109995)

* [APM] Fix for no-data state for fallback from aggregated transactions (elastic#109609)

* PR feedback and unit tests

* fixes lint error

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
ogupte added a commit to ogupte/kibana that referenced this pull request Aug 31, 2021
…elastic#109995)

* [APM] Fix for no-data state for fallback from aggregated transactions (elastic#109609)

* PR feedback and unit tests

* fixes lint error

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
ogupte added a commit that referenced this pull request Sep 1, 2021
…#109995) (#110624)

* [APM] Fix for no-data state for fallback from aggregated transactions (#109609)

* PR feedback and unit tests

* fixes lint error

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
ogupte added a commit that referenced this pull request Sep 1, 2021
…#109995) (#110625)

* [APM] Fix for no-data state for fallback from aggregated transactions (#109609)

* PR feedback and unit tests

* fixes lint error

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.15.0 v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Warning about transaction-based-ui is shown when there's no data
4 participants