Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove index pattern placeholder advanced setting #110334

Merged
merged 2 commits into from Aug 26, 2021
Merged

Remove index pattern placeholder advanced setting #110334

merged 2 commits into from Aug 26, 2021

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Aug 26, 2021 •
edited

Summary

Removes the index pattern placeholder advanced setting -

Screen Shot 2021-08-24 at 5 33 59 PM

This wasn't properly implemented in the new index pattern creation flyout - #101853 . The reason why it was implemented is no longer relevant - #5818

Release notes

The index pattern placeholder advanced setting has been removed as part of the redesign of the new index pattern creation flyout.

@mattkime mattkime requested a review from a team as a code owner August 26, 2021 20:15
@mattkime mattkime added v7.15.0 v7.16.0 v8.0.0 Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:AppServices labels Aug 26, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

dokmic
dokmic approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@dokmic dokmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mattkime mattkime added auto-backport Deprecated: Automatically backport this PR after it's merged Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages labels Aug 26, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 775.6KB 775.6KB -52.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime merged commit 8babdc2 into elastic:master Aug 26, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 26, 2021
@mattkime @kibanamachine
Remove index pattern placeholder advanced setting (elastic#110334)
2316960 
* remove index pattern placeholder setting

* remove unused translations
@kibanamachine kibanamachine mentioned this pull request Aug 26, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 26, 2021
@mattkime @kibanamachine
Remove index pattern placeholder advanced setting (elastic#110334)
32c19d1 
* remove index pattern placeholder setting

* remove unused translations
@kibanamachine kibanamachine mentioned this pull request Aug 26, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.15
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 27, 2021
@kibanamachine @mattkime
Remove index pattern placeholder advanced setting (#110334) (#110375)
49eaef3 
* remove index pattern placeholder setting

* remove unused translations

Co-authored-by: Matthew Kime <matt@mattki.me>
kibanamachine added a commit that referenced this pull request Aug 28, 2021
@kibanamachine @mattkime
[7.15] Remove index pattern placeholder advanced setting (#110334) (#…
1cd0d6f 
…110374)

* Remove index pattern placeholder advanced setting (#110334)

* remove index pattern placeholder setting

* remove unused translations

* update docs

Co-authored-by: Matthew Kime <matt@mattki.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dokmic dokmic dokmic approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:fix v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mattkime @elasticmachine @kibanamachine @dokmic