[Lens] Fix filters reappearing in the saved object when saving #110460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
added
release_note:fix
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
mbondyra
changed the title
mbondyra
commented
Aug 30, 2021
| @@ -384,51 +348,5 @@ export function getLastKnownDocWithoutPinnedFilters(doc?: Document) { | |||
| : doc; | |||
| } | |||
|
|
|||
| export const getPersistedDoc = async ({ | |||
There was a problem hiding this comment.
this piece is moved to another file.
mbondyra
commented
Aug 30, 2021
mbondyra
added
the
auto-backport
stratoula
approved these changes
Aug 30, 2021
3 tasks
mbondyra
force-pushed
the
lens/fix_filters_bug
branch
from
3766647
to
429a7e9
Compare
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 31, 2021
…ic#110460) * bugs fixed * test for loading * fix workspace panel * Update x-pack/plugins/lens/public/xy_visualization/visualization.tsx * revert useEffect for external embeddables
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 31, 2021
…ic#110460) * bugs fixed * test for loading * fix workspace panel * Update x-pack/plugins/lens/public/xy_visualization/visualization.tsx * revert useEffect for external embeddables
kibanamachine
added a commit
that referenced
this pull request
Aug 31, 2021
…) (#110590) * bugs fixed * test for loading * fix workspace panel * Update x-pack/plugins/lens/public/xy_visualization/visualization.tsx * revert useEffect for external embeddables Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Aug 31, 2021
…) (#110589) * bugs fixed * test for loading * fix workspace panel * Update x-pack/plugins/lens/public/xy_visualization/visualization.tsx * revert useEffect for external embeddables Co-authored-by: Marta Bondyra <marta.bondyra@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #110248
Also fixes the issue with loading empty document from the search bar. To reproduce, load existing document and then search for Lens new document in the top search bar - the bug was caused by not properly cleaning initial state for the empty state.
Checklist