[APM] Custom links creation don't work #110676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cauemarcondes
added
release_note:fix
Team:APM
|
Pinging @elastic/apm-ui (Team:apm) |
ogupte
approved these changes
Aug 31, 2021
|
jenkins, retest this please |
sorenlouv
reviewed
Aug 31, 2021
| cy.get('[data-test-subj="editCustomLink"]').click(); | ||
| cy.contains('Delete').click(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Thank you for adding this. Our new e2e suite is on fire (in the best possible way! :D )
sorenlouv
reviewed
Aug 31, 2021
| @@ -8,7 +8,7 @@ | |||
| declare namespace Cypress { | |||
| interface Chainable { | |||
| loginAsReadOnlyUser(): void; | |||
| loginAsSuperUser(): void; | |||
| loginAsPowerUser(): void; | |||
There was a problem hiding this comment.
Thanks for removing the superuser. We really should only use the two others.
Going forward I think we can replace our custom roles with the built in roles viewer and editor.
sorenlouv
approved these changes
Aug 31, 2021
There was a problem hiding this comment.
Thanks for the e2e test @cauemarcondes. Makes the code base much more solid going forward!
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 1, 2021
* fixing custom links issue * Removing unused imports
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 1, 2021
* fixing custom links issue * Removing unused imports
kibanamachine
added a commit
that referenced
this pull request
Sep 1, 2021
kibanamachine
added a commit
that referenced
this pull request
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #110607
I suspect that an update on EUI made this stop working. I fixed it by linking the form and the button.
I also created an e2e test to guarantee it keeps working on future updates.