New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Add host isolation exceptions UI #111253
[Security Solution] Add host isolation exceptions UI #111253
Conversation
8fea6e8
to
611319a
Compare
ef07fca
to
0ce0223
Compare
…ation_ips_whitelist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🐑
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 🔥 🔥
Suggestion: As there are some changes in the io-ts-list
package I would suggest you to add someone from security-detections-response team as a reviewer
x-pack/plugins/security_solution/public/management/pages/host_isolation_exceptions/service.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/management/pages/host_isolation_exceptions/service.ts
Show resolved
Hide resolved
page?: number; | ||
perPage?: number; | ||
sortField?: keyof ExceptionListItemSchema; | ||
sortOrder?: 'asc' | 'desc'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: We have a SortOrder
type that should be the same as re-doing this here but if you look across the code base the asc | desc
has been retyped so many times you can pull from any number of duplicate types or just leave this as is here.
...lugins/security_solution/public/management/pages/host_isolation_exceptions/store/builders.ts
Outdated
Show resolved
Hide resolved
...lugins/security_solution/public/management/pages/host_isolation_exceptions/store/builders.ts
Outdated
Show resolved
Hide resolved
...plugins/security_solution/public/management/pages/host_isolation_exceptions/store/reducer.ts
Show resolved
Hide resolved
...blic/management/pages/host_isolation_exceptions/view/host_isolation_exceptions_list.test.tsx
Show resolved
Hide resolved
packages/kbn-securitysolution-io-ts-list-types/src/common/exception_list/index.ts
Show resolved
Hide resolved
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Allows the rule to be duplicated from the edit screen.indicator match Detection rules, Indicator Match Duplicates the indicator rule Allows the rule to be duplicated from the edit screenStack Trace
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Summary
Adds host isolation exceptions. This is the first of a series of PR to introduce the full functionality.
This first PR:
Note: No adding/editing/deleting functionality is introduced in this PR. These features will come in subsequent ones.
Notes to reviewers:
This PR consists of the following main parts:
x-pack/plugins/security_solution/public/management/pages/host_isolation_exceptions/**
Checklist
Delete any items that are not applicable to this PR.