Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first pass of autocomplete to input controls #112168

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

poffdeluxe
Copy link
Contributor

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 14, 2021

💔 Build Failed

Failed CI Steps


Test Failures

Kibana Pipeline / jest / Jest Tests.src/plugins/dashboard/public/application/hooks.Dashboard container lifecycle Dashboard container is destroyed on unmount

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

Error: optionsListControl can't be loaded. Please upgrade to the default distribution of Elasticsearch and Kibana with the appropriate license.
    at DashboardContainer.addNewEmbeddable (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/embeddable/public/lib/containers/container.ts:106:13)
    at buildDashboardContainer (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/dashboard/public/application/lib/build_dashboard_container.ts:175:22)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/dashboard/public/application/hooks/use_dashboard_app_state.ts:188:34

Kibana Pipeline / jest / Jest Tests.src/plugins/dashboard/public/application/hooks.Dashboard container lifecycle Old dashboard container is destroyed when new dashboardId is given

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

Error: optionsListControl can't be loaded. Please upgrade to the default distribution of Elasticsearch and Kibana with the appropriate license.
    at DashboardContainer.addNewEmbeddable (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/embeddable/public/lib/containers/container.ts:106:13)
    at buildDashboardContainer (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/dashboard/public/application/lib/build_dashboard_container.ts:175:22)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/dashboard/public/application/hooks/use_dashboard_app_state.ts:188:34

Kibana Pipeline / jest / Jest Tests.src/plugins/dashboard/public/application/hooks.Dashboard container lifecycle Dashboard container is destroyed if dashboard id is changed before container is resolved

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

Error: expect(jest.fn()).not.toBeCalled()

Expected number of calls: 0
Received number of calls: 1

1: called with 0 arguments
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/dashboard/public/application/hooks/use_dashboard_app_state.test.tsx:201:58)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

and 26 more failures, only showing the first 3.

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
presentationUtil 119 136 +17

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
presentationUtil 151 177 +26

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 223.1KB 223.4KB +286.0B
presentationUtil 68.2KB 68.3KB +22.0B
total +308.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
presentationUtil 5 7 +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 327.4KB 327.8KB +417.0B
presentationUtil 69.8KB 90.5KB +20.7KB
total +21.1KB
Unknown metric groups

API count

id before after diff
presentationUtil 178 204 +26

References to deprecated APIs

id before after diff
presentationUtil 13 34 +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants