[7.x] Improve deprecation message for xpack.spaces.enabled #112242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watson
added
release_note:skip
jportner
reviewed
Sep 15, 2021
KOTungseth
reviewed
Sep 15, 2021
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
watson
commented
Sep 15, 2021
jportner
reviewed
Sep 15, 2021
watson
commented
Sep 21, 2021
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
jportner
approved these changes
Sep 29, 2021
There was a problem hiding this comment.
Thanks for updating this, LGTM.
Here is the current screenshot:
As discussed in #112242 (comment), there is a separate issue to render a single-step corrective action as a paragraph instead of a list.
debadair
reviewed
Oct 1, 2021
watson
commented
Oct 6, 2021
Co-authored-by: debadair <debadair@elastic.co>
watson
commented
Oct 6, 2021
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @watson |
100 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #82467
This PR improves the deprecation message for if
xpack.spaces.enabledis set tofalseinkibana.yml. This message also currently exists inmaster. However, I'll make another PR to remove it frommasteras this is going away in 8.0.Here's how the new message will look in the Upgrade Assistant UI: