Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated kbn-system-api header support #112505

Merged
merged 1 commit into from Sep 18, 2021
Merged

Remove deprecated kbn-system-api header support #112505

merged 1 commit into from Sep 18, 2021

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Sep 17, 2021 •
edited

Summary

Stumbled upon a tiny change, so decided to spend 5 min. to implement it.
Closes #55203

Risk Matrix

Risk Probability Severity Mitigation/Notes
3rd party plugins use the header Low Low Some Kibana plugins created outside of the Kibana codebase might use this header even though it's considered to be an internal API.

Plugin API changes

Kibana removed support of deprecated kbn-system-api header. Instead, use asSystemRequest flag:

const response = await core.http.get({
  path: '/url',
  asSystemRequest: true,
});

@mshustov mshustov added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v8.0.0 backport:skip This commit does not require backporting labels Sep 17, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov marked this pull request as ready for review September 17, 2021 12:26
@mshustov mshustov requested a review from a team as a code owner September 17, 2021 12:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@mshustov mshustov merged commit 4a1a060 into elastic:master Sep 18, 2021
@mshustov mshustov deleted the issue-55203 branch September 18, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove support for kbn-system-api header
4 participants
@mshustov @kibanamachine @elasticmachine @pgayvallet