[RAC] Link inventory alerts to the right inventory view #113553
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import React from 'react'; | ||
| import { parse } from 'query-string'; | ||
| import { Redirect, RouteComponentProps } from 'react-router-dom'; | ||
|
|
||
| // FIXME what would be the right way to build this query string? | ||
|
There was a problem hiding this comment. If we cannot find a good way in this PR we can address this later. If I recall correctly Kibana provides a service already to create good URLs? Maybe it's worth leaving this as is and wait until that service is used in Metrics to update this code There was a problem hiding this comment. You would need to use the As for the There was a problem hiding this comment. I'm more concerned about what happens if/when the parameters in the URL change. It feels I'm duplicating things here and it's just a matter of time until it gets changed somewhere else and this breaks. Is there something in metrics to generate valid URLs? There was a problem hiding this comment. Mmm, apparently the I think moving forward it's better to leave the code as it is now (revisiting how the query string is constructed). What do you think @simianhacker? |
||
| const QUERY_STRING_TEMPLATE = | ||
| "?waffleFilter=(expression:'',kind:kuery)&waffleTime=(currentTime:{timestamp},isAutoReloading:!f)&waffleOptions=(accountId:'',autoBounds:!t,boundsOverride:(max:1,min:0),customMetrics:!({customMetric}),customOptions:!(),groupBy:!(),legend:(palette:cool,reverseColors:!f,steps:10),metric:{metric},nodeType:{nodeType},region:'',sort:(by:name,direction:desc),timelineOpen:!f,view:map)"; | ||
|
|
||
| export const RedirectToInventory: React.FC<RouteComponentProps> = ({ location }) => { | ||
| const parsedQueryString = parseQueryString(location.search); | ||
|
|
||
| const inventoryQueryString = QUERY_STRING_TEMPLATE.replace( | ||
| /{(\w+)}/g, | ||
| (_, key) => parsedQueryString[key] || '' | ||
| ); | ||
|
|
||
| return <Redirect to={'/inventory' + inventoryQueryString} />; | ||
| }; | ||
|
|
||
| function parseQueryString(search: string): Record<string, string> { | ||
| if (search.length === 0) { | ||
| return {}; | ||
| } | ||
|
|
||
| const obj = parse(search.substring(1)); | ||
|
|
||
| // Force all values into string. If they are empty don't create the keys | ||
| for (const key in obj) { | ||
| if (Object.hasOwnProperty.call(obj, key)) { | ||
| if (!obj[key]) { | ||
| delete obj[key]; | ||
| } | ||
| if (Array.isArray(obj.key)) { | ||
| obj[key] = obj[key]![0]; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return obj as Record<string, string>; | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably use
getUrlForApphere as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not used within a React context so calling
useKibanais not possible. I'm looking how easy is to inject the kibana services and it's not that straightforward.The link is correctly prefixed when used (the
prepend()call in the linked code), so I wonder if that's good enough.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shakes fist at sky "Damn you hooks!"