[test/dashboard] Retry filter check #11372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!resp.length) throw new Error('expected filters'); | ||
| return resp; | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Since everything else is using await, could maybe follow suit and do:
// Try until we get filters back to avoid a potential timing issue.
// See https://github.com/elastic/kibana/issues/11339 for more info.
const originalFilters = await retry.try(async () => {
const filters = await PageObjects.dashboard.getFilters();
if (!filters.length) throw new Error('expected filters');
return filters;
});
Take it or leave it, just personal preference that it looks better to my eyes. Thanks for (hopefully) fixing this!
stacey-gammon
approved these changes
Apr 21, 2017
Closed
jbudz
added a commit
that referenced
this pull request
Apr 21, 2017
* [test/dashboard] Retry filter check * [test/dashboard] Use await on getFilters
jbudz
added a commit
that referenced
this pull request
Apr 21, 2017
* [test/dashboard] Retry filter check * [test/dashboard] Use await on getFilters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe findAllByCssSelector is perfectly happy with returning 0 results and not waiting, so this wraps the getFilters method in a retry block.
Attempt at fixing #11339