test support #11477
Merged
test support #11477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure: jenkins, test this |
stacey-gammon
force-pushed
the
reporting-functional-tests
branch
3 times, most recently
from
1f2a446
to
e481fb6
Compare
|
jenkins, test this (seeing if it fails due to JedWatson/react-select#1694) |
kobelb
approved these changes
May 1, 2017
stacey-gammon
force-pushed
the
reporting-functional-tests
branch
from
e481fb6
to
2292c81
Compare
stacey-gammon
force-pushed
the
reporting-functional-tests
branch
from
2292c81
to
fbb7889
Compare
|
s3 error. Jenkins, test this |
spalger
reviewed
May 4, 2017
| return await remote.findDisplayedByCssSelector('kbn-truncated.toast-message.ng-isolate-scope') | ||
| .getVisibleText(); | ||
| async getToastMessage(findTimeout = defaultFindTimeout) { | ||
| await remote.setFindTimeout(findTimeout); |
There was a problem hiding this comment.
Something to keep in mind for future PRs, it's be nice to add stuff like this to the find service
There was a problem hiding this comment.
ah, so then instead of remote.findDisplayedByCssSelector, we'd add a new function to find so that we can stuff overriding the custom timeout in there, and then use find.displayedByCssSelector and pass the extra findTimeout?
Seems to work locally like this.
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
May 6, 2017
* test support * Move custom find timeout logic into find service * Fix the error in tests by combining the calls. Seems to work locally like this.
stacey-gammon
added a commit
that referenced
this pull request
May 7, 2017
snide
pushed a commit
to snide/kibana
that referenced
this pull request
May 30, 2017
* test support * Move custom find timeout logic into find service * Fix the error in tests by combining the calls. Seems to work locally like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few details for additional tests to be written.