-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test support #11477
test support #11477
Conversation
Failure:
jenkins, test this |
1f2a446
to
e481fb6
Compare
jenkins, test this (seeing if it fails due to JedWatson/react-select#1694) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - pending successful CI builds
e481fb6
to
2292c81
Compare
2292c81
to
fbb7889
Compare
s3 error. Jenkins, test this |
return await remote.findDisplayedByCssSelector('kbn-truncated.toast-message.ng-isolate-scope') | ||
.getVisibleText(); | ||
async getToastMessage(findTimeout = defaultFindTimeout) { | ||
await remote.setFindTimeout(findTimeout); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something to keep in mind for future PRs, it's be nice to add stuff like this to the find
service
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, so then instead of remote.findDisplayedByCssSelector
, we'd add a new function to find so that we can stuff overriding the custom timeout in there, and then use find.displayedByCssSelector
and pass the extra findTimeout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Seems to work locally like this.
* test support * Move custom find timeout logic into find service * Fix the error in tests by combining the calls. Seems to work locally like this.
* test support * Move custom find timeout logic into find service * Fix the error in tests by combining the calls. Seems to work locally like this.
A few details for additional tests to be written.