Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Framework] Wrap Cards within a non-united CardGroup. #11704

Merged
merged 2 commits into from
May 11, 2017

Conversation

cjcenizal
Copy link
Contributor

Addresses #11678

@cjcenizal cjcenizal added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v5.5.0 v6.0.0 labels May 10, 2017
@cjcenizal
Copy link
Contributor Author

@ycombinator This can be used in the Getting Started page. Could you take a look and let me know if the markup makes sense to you?

@ycombinator
Copy link
Contributor

Tested this PR with #11673 and the fix works as expected:

may-11-2017 14-03-43

Reviewing code now...

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Nice to have but not necessary: It would be nice to show in the UI Framework an example of two (non-united) cards side-by-side that stack on top of each other when the window width is reduced.

}

/**
* 1. Use the defined width of the card to determine when to wrap.
* 2. Use an event margin all around the card so that the spacing is still even when wrapped.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Use an even margin all...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eagle eyes!

@cjcenizal
Copy link
Contributor Author

@ycombinator Thanks man, FYI the example you suggested already exists under the Card example:

image

@cjcenizal cjcenizal merged commit 871b16d into elastic:master May 11, 2017
@cjcenizal cjcenizal deleted the 11678/improvement/wrap-card-group branch May 11, 2017 21:58
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request May 11, 2017
cjcenizal added a commit that referenced this pull request May 11, 2017
snide pushed a commit to snide/kibana that referenced this pull request May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:enhancement Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v5.5.0 v6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants