-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI Framework] Wrap Cards within a non-united CardGroup. #11704
[UI Framework] Wrap Cards within a non-united CardGroup. #11704
Conversation
@ycombinator This can be used in the Getting Started page. Could you take a look and let me know if the markup makes sense to you? |
Tested this PR with #11673 and the fix works as expected: Reviewing code now... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Nice to have but not necessary: It would be nice to show in the UI Framework an example of two (non-united) cards side-by-side that stack on top of each other when the window width is reduced.
} | ||
|
||
/** | ||
* 1. Use the defined width of the card to determine when to wrap. | ||
* 2. Use an event margin all around the card so that the spacing is still even when wrapped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: Use an even margin all...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eagle eyes!
@ycombinator Thanks man, FYI the example you suggested already exists under the Card example: |
* Wrap Cards within a non-united CardGroup.
* Wrap Cards within a non-united CardGroup.
Addresses #11678