Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Listing Page Callout When New Dashboard In Progress #117237

Conversation

ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Nov 2, 2021

Summary

Fixes #117025

When the user has no dashboards available, but has an unsaved dashboard in progress, the user will now see a callout to continue editing or discard the changes to their unsaved dashboard. Thanks to @KOTungseth for the copy.

When the user has no dashboards but has an unsaved dashboard in progress
Screen Shot 2021-11-03 at 12 20 14 PM

When the user has no dashboards and no unsaved dashboard in progress
Screen Shot 2021-11-03 at 12 26 59 PM

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features release_note:fix v8.1.0 v9.0.0 Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Nov 3, 2021
@ThomThomson ThomThomson force-pushed the dashboardListing/showUnsavedWhenNoDashboards branch from f03e336 to 31890f1 Compare November 3, 2021 18:45
@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream main

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 275.7KB 276.4KB +769.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 65.0KB 65.1KB +134.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson marked this pull request as ready for review November 4, 2021 14:39
@ThomThomson ThomThomson requested a review from a team as a code owner November 4, 2021 14:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Nov 4, 2021
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great for me 👍

@ThomThomson ThomThomson merged commit 5d5fb3f into elastic:main Nov 5, 2021
@ThomThomson ThomThomson removed the v9.0.0 label Nov 5, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 9, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 117237 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 117237 or prevent reminders by adding the backport:skip label.

@ThomThomson ThomThomson added the backport:skip This commit does not require backporting label Nov 10, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dashboards] Bug: For the empty dashboards list unsaved changes to new dashboard does not show up.
4 participants