-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Show callout when EPR unavailable #117598
Merged
thomasneirynck
merged 16 commits into
elastic:main
from
thomasneirynck:fleet/epr_unavailable
Nov 9, 2021
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1605877
tmp
thomasneirynck e228cbb
Merge branch 'master' of github.com:elastic/kibana into fleet/epr_una…
thomasneirynck 3b898da
Merge branch 'master' of github.com:elastic/kibana into fleet/epr_una…
thomasneirynck 615bfcb
Merge branch 'main' of github.com:elastic/kibana into fleet/epr_unava…
thomasneirynck c9f4009
boilerplate
thomasneirynck 913fc08
remove cruft
thomasneirynck 4fe3d4c
more cruft removal
thomasneirynck a19c0c8
use doclinks
thomasneirynck 4db1e6f
fix link
thomasneirynck 958875b
update doc api
thomasneirynck 00d6b77
Merge branch 'main' of github.com:elastic/kibana into fleet/epr_unava…
thomasneirynck 83b117b
Merge branch 'main' of github.com:elastic/kibana into fleet/epr_unava…
thomasneirynck a101fed
change t4ext based on type of error
thomasneirynck 9269e62
copy
thomasneirynck 6dbf556
Merge branch 'main' of github.com:elastic/kibana into fleet/epr_unava…
thomasneirynck f693ab9
feedback
thomasneirynck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding explicit check on both, even though RegistryConnectionError subclasses from RegistryError. It may help as in-code documentation, and doesn't tie it as much to class-hierarchy.