Fixes error in Percentile for Time Series Visual Builder #11772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
added
Feature:TSVB
|
No more errors to stdout but I'm still getting |
|
@jbudz Yes... It's because you haven't selected a target field so it can't run the aggregation your asking for. There probably needs to be a better error message. |
jbudz
approved these changes
May 12, 2017
|
jenkins, test this |
thomasneirynck
approved these changes
May 26, 2017
simianhacker
added a commit
that referenced
this pull request
May 26, 2017
|
Back ported to 5.x with d6501e8 |
snide
pushed a commit
to snide/kibana
that referenced
this pull request
May 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to the getAggValue() method to for percentile to check for a parent object to exist. It fixes #11763