[server/validate] respond with all validation errors #11776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbudz
approved these changes
May 12, 2017
Probably, good point. |
spalger
added a commit
that referenced
this pull request
May 15, 2017
* [server/validate] respond with all validation errors * [server/config] fail with all validation errors (cherry picked from commit 866bf5d)
snide
pushed a commit
to snide/kibana
that referenced
this pull request
May 30, 2017
* [server/validate] respond with all validation errors * [server/config] fail with all validation errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using route param validation, the default for Joi is currently enabled which stops validating as soon as any error is found. This is fine, but I think showing all errors is better, and it makes routes easier to test.