Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing shakespeare bulk upload command for 6.0 #11795

Merged
merged 6 commits into from
May 16, 2017

Conversation

bhavyarm
Copy link
Contributor

Changing the bulk upload command for shakespeare.json to work with the new data file for 6.0.0 release.

We need to use a different path for 6.x(master) and 5.x for shakespeare.json now.
Sending the shakespeare.json to Court to get the new path.

@bhavyarm
Copy link
Contributor Author

@jbudz waiting for @epixa to give me the path for the file. I think we might just be changing the name of the file. Thanks!

@epixa
Copy link
Contributor

epixa commented May 15, 2017

@bhavyarm https://download.elastic.co/demos/kibana/gettingstarted/shakespeare_6.0.json

@jbudz
Copy link
Member

jbudz commented May 15, 2017

@bhavyarm now that we're using a single type, I would change the mappings from _default_ to use the doc type instead

changing the file path for shakespeare and the mapping type from default to doc
@bhavyarm bhavyarm force-pushed the bhavyarm-shakespeare_changes branch from da9244c to c93e3d7 Compare May 15, 2017 18:42
@jbudz
Copy link
Member

jbudz commented May 15, 2017

@epixa do we have a way to set the content type so it downloads instead of opens in the browser?

@epixa
Copy link
Contributor

epixa commented May 15, 2017

@jbudz Good call. Try now

Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR and download LGTM

@epixa
Copy link
Contributor

epixa commented May 15, 2017

Please remove the WIP from the title before merging

@bhavyarm bhavyarm changed the title [WIP]Changing shakespeare bulk upload command for 6.0 Changing shakespeare bulk upload command for 6.0 May 15, 2017
@bhavyarm bhavyarm merged commit a3a642c into elastic:master May 16, 2017
@bhavyarm bhavyarm deleted the bhavyarm-shakespeare_changes branch May 16, 2017 17:49
snide pushed a commit to snide/kibana that referenced this pull request May 30, 2017
* Changing shakespeare bulk upload command for 6.0

* file path and mapping change

changing the file path for shakespeare and the mapping type from default to doc

* removing underscore for doc and changing file name

* removing extra spaces in the map shakespeare command

* removing  spaces before the colon

* removing extra spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants