Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[indexedArray] es6-ify #11800

Merged
merged 1 commit into from
May 15, 2017
Merged

Conversation

spalger
Copy link
Contributor

@spalger spalger commented May 15, 2017

Just refactored the IndexedArray class to be an es6 class

@spalger spalger added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc chore v5.5.0 v6.0.0 labels May 15, 2017
@spalger spalger requested a review from ppisljar May 15, 2017 19:09
if (config.immutable) {
// just a hint, bugs caused by updates not propogating would be very
// very very hard to track down
this.push = this.splice = undefined;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was loosing this intentional ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, they are now implemented as methods and throw descriptive errors when immutable is turned on (it also covers all of the mutable methods, not just push and splice).

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalger spalger merged commit 12e56b8 into elastic:master May 15, 2017
spalger added a commit that referenced this pull request May 15, 2017
(cherry picked from commit 12e56b8)
@spalger
Copy link
Contributor Author

spalger commented May 15, 2017

5.x/5.5: 367babc

snide pushed a commit to snide/kibana that referenced this pull request May 30, 2017
@spalger spalger deleted the es6-ify/indexed_array branch October 18, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v5.5.0 v6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants